Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No option for http_proxy #124

Closed
simonmorley opened this issue Mar 1, 2014 · 4 comments
Closed

No option for http_proxy #124

simonmorley opened this issue Mar 1, 2014 · 4 comments
Labels

Comments

@simonmorley
Copy link

We require an outbound proxy on our servers and have had to fork and temp. patch to facilitate.

Am I correct in assuming there's no option here for a proxy? If so, we'll test our patch some more and send a pull req.

-- EDIT --

Actually our fix didn't work. Initially, we inserted:

RestClient.proxy = "http://proxy.example.com/"

Into lib/stripe.rb to test. On dev. this worked but on Production we found it overrides all outbound requests, which we can't do.

@fables-tales
Copy link

👍

@brandur
Copy link
Contributor

brandur commented Sep 29, 2015

Sorry for the delay in response on this one! Thanks for reporting.

As described in #219, I think it would be nice to upgrade some of the gem's HTTP infrastructure. I'll try to consider the requirement here as we patch that.

@brandur
Copy link
Contributor

brandur commented Oct 2, 2015

Created umbrella issue #313 and am closing this in favor of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants
@fables-tales @brandur @amfeng @simonmorley and others