/
api_resource_test.rb
646 lines (534 loc) · 24.6 KB
/
api_resource_test.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
# frozen_string_literal: true
require ::File.expand_path("../test_helper", __dir__)
module Stripe
class ApiResourceTest < Test::Unit::TestCase
class CustomMethodAPIResource < APIResource
OBJECT_NAME = "custom_method"
custom_method :my_method, http_verb: :post
end
class NestedTestAPIResource < APIResource
save_nested_resource :external_account
end
context ".custom_method" do
should "call to an RPC-style method" do
stub_request(:post, "#{Stripe.api_base}/v1/custom_methods/ch_123/my_method")
.to_return(body: JSON.generate({}))
CustomMethodAPIResource.my_method("ch_123")
end
should "raise an error if a non-ID is passed" do
e = assert_raises ArgumentError do
CustomMethodAPIResource.my_method(id: "ch_123")
end
assert_equal "id should be a string representing the ID of an API resource",
e.message
end
end
context ".save_nested_resource" do
should "can have a scalar set" do
r = NestedTestAPIResource.new("test_resource")
r.external_account = "tok_123"
assert_equal "tok_123", r.external_account
end
should "set a flag if given an object source" do
r = NestedTestAPIResource.new("test_resource")
r.external_account = {
object: "card",
}
assert_equal true, r.external_account.save_with_parent
end
end
should "creating a new APIResource should not fetch over the network" do
Stripe::Customer.new("someid")
assert_not_requested :get, %r{#{Stripe.api_base}/.*}
end
should "creating a new APIResource from a hash should not fetch over the network" do
Stripe::Customer.construct_from(id: "somecustomer",
card: { id: "somecard", object: "card" },
object: "customer")
assert_not_requested :get, %r{#{Stripe.api_base}/.*}
end
should "setting an attribute should not cause a network request" do
c = Stripe::Customer.new("cus_123")
c.card = { id: "somecard", object: "card" }
assert_not_requested :get, %r{#{Stripe.api_base}/.*}
assert_not_requested :post, %r{#{Stripe.api_base}/.*}
end
should "accessing id should not issue a fetch" do
c = Stripe::Customer.new("cus_123")
c.id
assert_not_requested :get, %r{#{Stripe.api_base}/.*}
end
should "not specifying api credentials should raise an exception" do
Stripe.api_key = nil
assert_raises Stripe::AuthenticationError do
Stripe::Customer.new("cus_123").refresh
end
end
should "using a nil api key should raise an exception" do
assert_raises TypeError do
Stripe::Customer.list({}, nil)
end
assert_raises TypeError do
Stripe::Customer.list({}, api_key: nil)
end
end
should "specifying api credentials containing whitespace should raise an exception" do
Stripe.api_key = "key "
assert_raises Stripe::AuthenticationError do
Stripe::Customer.new("cus_123").refresh
end
end
should "send expand on fetch properly" do
stub_request(:get, "#{Stripe.api_base}/v1/charges/ch_123")
.with(query: { "expand" => ["customer"] })
.to_return(body: JSON.generate(charge_fixture))
Stripe::Charge.retrieve(id: "ch_123", expand: [:customer])
end
should "preserve expand across refreshes" do
stub_request(:get, "#{Stripe.api_base}/v1/charges/ch_123")
.with(query: { "expand" => ["customer"] })
.to_return(body: JSON.generate(charge_fixture))
ch = Stripe::Charge.retrieve(id: "ch_123", expand: [:customer])
ch.refresh
end
should "send expand when fetching through ListObject" do
stub_request(:get, "#{Stripe.api_base}/v1/charges/ch_123")
.to_return(body: JSON.generate(charge_fixture))
stub_request(:get, "#{Stripe.api_base}/v1/charges/ch_123/refunds/re_123")
.with(query: { "expand" => ["balance_transaction"] })
.to_return(body: JSON.generate(charge_fixture))
charge = Stripe::Charge.retrieve("ch_123")
charge.refunds.retrieve(id: "re_123", expand: [:balance_transaction])
end
context "when specifying per-object credentials" do
context "with no global API key set" do
should "use the per-object credential when creating" do
stub_request(:post, "#{Stripe.api_base}/v1/charges")
.with(headers: { "Authorization" => "Bearer sk_test_local" })
.to_return(body: JSON.generate(charge_fixture))
Stripe::Charge.create({ source: "tok_visa" },
"sk_test_local")
end
end
context "with a global API key set" do
setup do
Stripe.api_key = "global"
end
teardown do
Stripe.api_key = nil
end
should "use the per-object credential when creating" do
stub_request(:post, "#{Stripe.api_base}/v1/charges")
.with(headers: { "Authorization" => "Bearer sk_test_local" })
.to_return(body: JSON.generate(charge_fixture))
Stripe::Charge.create({ source: "tok_visa" },
"sk_test_local")
end
should "use the per-object credential when retrieving and making other calls" do
stub_request(:get, "#{Stripe.api_base}/v1/charges/ch_123")
.with(headers: { "Authorization" => "Bearer sk_test_local" })
.to_return(body: JSON.generate(charge_fixture))
stub_request(:post, "#{Stripe.api_base}/v1/charges/ch_123/refunds")
.with(headers: { "Authorization" => "Bearer sk_test_local" })
.to_return(body: "{}")
ch = Stripe::Charge.retrieve("ch_123", "sk_test_local")
ch.refunds.create
end
end
end
context "with valid credentials" do
should "urlencode values in GET params" do
stub_request(:get, "#{Stripe.api_base}/v1/charges")
.with(query: { customer: "test customer" })
.to_return(body: JSON.generate(data: [charge_fixture]))
charges = Stripe::Charge.list(customer: "test customer").data
assert charges.is_a? Array
end
should "construct URL properly with base query parameters" do
stub_request(:get, "#{Stripe.api_base}/v1/charges")
.with(query: { customer: "cus_123" })
.to_return(body: JSON.generate(data: [charge_fixture],
url: "/v1/charges"))
charges = Stripe::Charge.list(customer: "cus_123")
stub_request(:get, "#{Stripe.api_base}/v1/charges")
.with(query: { customer: "cus_123", created: "123" })
.to_return(body: JSON.generate(data: [charge_fixture],
url: "/v1/charges"))
charges.list(created: 123)
end
should "setting a nil value for a param should exclude that param from the request" do
stub_request(:get, "#{Stripe.api_base}/v1/charges")
.with(query: { offset: 5, sad: false })
.to_return(body: JSON.generate(count: 1, data: [charge_fixture]))
Stripe::Charge.list(count: nil, offset: 5, sad: false)
stub_request(:post, "#{Stripe.api_base}/v1/charges")
.with(body: { "amount" => "50", "currency" => "usd" })
.to_return(body: JSON.generate(count: 1, data: [charge_fixture]))
Stripe::Charge.create(amount: 50, currency: "usd", card: { number: nil })
end
should "not trigger a warning if a known opt, such as idempotency_key, is in opts" do
stub_request(:post, "#{Stripe.api_base}/v1/charges")
.to_return(body: JSON.generate(charge_fixture))
old_stderr = $stderr
$stderr = StringIO.new
begin
Stripe::Charge.create({ amount: 100, currency: "usd", card: "sc_token" }, idempotency_key: "12345")
assert $stderr.string.empty?
ensure
$stderr = old_stderr
end
end
should "trigger a warning if a known opt, such as idempotency_key, is in params" do
stub_request(:post, "#{Stripe.api_base}/v1/charges")
.to_return(body: JSON.generate(charge_fixture))
old_stderr = $stderr
$stderr = StringIO.new
begin
Stripe::Charge.create(amount: 100, currency: "usd", card: "sc_token", idempotency_key: "12345")
assert_match Regexp.new("WARNING:"), $stderr.string
ensure
$stderr = old_stderr
end
end
should "error if the params is not a Hash" do
stub_request(:post, "#{Stripe.api_base}/v1/charges/ch_123/capture")
.to_return(body: JSON.generate(charge_fixture))
e = assert_raises(ArgumentError) { Stripe::Charge.capture("ch_123", "sk_test_secret") }
assert_equal "request params should be either a Hash or nil (was a String)", e.message
end
should "allow making a request with params set to nil" do
stub_request(:post, "#{Stripe.api_base}/v1/charges/ch_123/capture")
.to_return(body: JSON.generate(charge_fixture))
Stripe::Charge.capture("ch_123", nil, "sk_test_secret")
end
should "error if a user-specified opt is given a non-nil non-string value" do
stub_request(:post, "#{Stripe.api_base}/v1/charges")
.to_return(body: JSON.generate(charge_fixture))
# Works fine if not included or a string.
Stripe::Charge.create({ amount: 100, currency: "usd" }, {})
Stripe::Charge.create({ amount: 100, currency: "usd" }, idempotency_key: "12345")
# Errors on a non-string.
e = assert_raises(ArgumentError) do
Stripe::Charge.create({ amount: 100, currency: "usd" }, idempotency_key: :foo)
end
assert_equal "request option 'idempotency_key' should be a string value " \
"(was a Symbol)",
e.message
end
should "requesting with a unicode ID should result in a request" do
stub_request(:get, "#{Stripe.api_base}/v1/customers/%E2%98%83")
.to_return(body: JSON.generate(make_missing_id_error), status: 404)
c = Stripe::Customer.new("☃")
assert_raises(Stripe::InvalidRequestError) { c.refresh }
end
should "requesting with no ID should result in an InvalidRequestError with no request" do
c = Stripe::Customer.new
assert_raises(Stripe::InvalidRequestError) { c.refresh }
end
should "making a GET request with parameters should have a query string and no body" do
stub_request(:get, "#{Stripe.api_base}/v1/charges")
.with(query: { limit: 1 })
.to_return(body: JSON.generate(data: [charge_fixture]))
Stripe::Charge.list(limit: 1)
end
should "making a POST request with parameters should have a body and no query string" do
stub_request(:post, "#{Stripe.api_base}/v1/charges")
.with(body: { "amount" => "100", "currency" => "usd", "card" => "sc_token" })
.to_return(body: JSON.generate(charge_fixture))
Stripe::Charge.create(amount: 100, currency: "usd", card: "sc_token")
end
should "loading an object should issue a GET request" do
stub_request(:get, "#{Stripe.api_base}/v1/charges/ch_123")
.to_return(body: JSON.generate(charge_fixture))
c = Stripe::Charge.new("ch_123")
c.refresh
end
should "using array accessors should be the same as the method interface" do
stub_request(:get, "#{Stripe.api_base}/v1/charges/ch_123")
.to_return(body: JSON.generate(charge_fixture))
c = Stripe::Charge.new("cus_123")
c.refresh
assert_equal c.created, c[:created]
assert_equal c.created, c["created"]
c["created"] = 12_345
assert_equal c.created, 12_345
end
should "updating an object should issue a POST request with only the changed properties" do
stub_request(:post, "#{Stripe.api_base}/v1/customers/cus_123")
.with(body: { "description" => "another_mn" })
.to_return(body: JSON.generate(customer_fixture))
c = Stripe::Customer.construct_from(customer_fixture)
c.description = "another_mn"
c.save
end
should "updating should merge in returned properties" do
stub_request(:post, "#{Stripe.api_base}/v1/customers/cus_123")
.with(body: { "description" => "another_mn" })
.to_return(body: JSON.generate(customer_fixture))
c = Stripe::Customer.new("cus_123")
c.description = "another_mn"
c.save
assert_equal false, c.livemode
end
should "updating should fail if api_key is overwritten with nil" do
c = Stripe::Customer.new
assert_raises TypeError do
c.save({}, api_key: nil)
end
end
should "updating should use the supplied api_key" do
stub_request(:post, "#{Stripe.api_base}/v1/customers")
.with(headers: { "Authorization" => "Bearer sk_test_local" })
.to_return(body: JSON.generate(customer_fixture))
c = Stripe::Customer.new
c.save({}, api_key: "sk_test_local")
assert_equal false, c.livemode
end
should "deleting should send no props and result in an object that has no props other deleted" do
stub_request(:delete, "#{Stripe.api_base}/v1/customers/cus_123")
.to_return(body: JSON.generate("id" => "cus_123", "deleted" => true))
c = Stripe::Customer.construct_from(customer_fixture)
c.delete
end
should "loading all of an APIResource should return an array of recursively instantiated objects" do
stub_request(:get, "#{Stripe.api_base}/v1/charges")
.to_return(body: JSON.generate(data: [charge_fixture]))
charges = Stripe::Charge.list.data
assert charges.is_a? Array
assert charges[0].is_a? Stripe::Charge
assert charges[0].payment_method_details.is_a?(Stripe::StripeObject)
end
should "passing in a stripe_account header should pass it through on call" do
stub_request(:get, "#{Stripe.api_base}/v1/customers/cus_123")
.with(headers: { "Stripe-Account" => "acct_123" })
.to_return(body: JSON.generate(customer_fixture))
Stripe::Customer.retrieve("cus_123", stripe_account: "acct_123")
end
should "passing in a stripe_account header should pass it through on save" do
stub_request(:get, "#{Stripe.api_base}/v1/customers/cus_123")
.with(headers: { "Stripe-Account" => "acct_123" })
.to_return(body: JSON.generate(customer_fixture))
c = Stripe::Customer.retrieve("cus_123", stripe_account: "acct_123")
stub_request(:post, "#{Stripe.api_base}/v1/customers/cus_123")
.with(headers: { "Stripe-Account" => "acct_123" })
.to_return(body: JSON.generate(customer_fixture))
c.description = "FOO"
c.save
end
should "add key to nested objects" do
acct = Stripe::Account.construct_from(id: "myid",
legal_entity: {
size: "l",
score: 4,
height: 10,
})
stub_request(:post, "#{Stripe.api_base}/v1/accounts/myid")
.with(body: { legal_entity: { first_name: "Bob" } })
.to_return(body: JSON.generate("id" => "myid"))
acct.legal_entity.first_name = "Bob"
acct.save
end
should "save nothing if nothing changes" do
acct = Stripe::Account.construct_from(id: "acct_id",
metadata: {
key: "value",
})
stub_request(:post, "#{Stripe.api_base}/v1/accounts/acct_id")
.with(body: {})
.to_return(body: JSON.generate("id" => "acct_id"))
acct.save
end
should "not save nested API resources" do
ch = Stripe::Charge.construct_from(id: "ch_id",
customer: {
object: "customer",
id: "customer_id",
})
stub_request(:post, "#{Stripe.api_base}/v1/charges/ch_id")
.with(body: {})
.to_return(body: JSON.generate("id" => "ch_id"))
ch.customer.description = "Bob"
ch.save
end
should "correctly handle replaced nested objects" do
acct = Stripe::Account.construct_from(
id: "acct_123",
company: {
name: "company_name",
address: {
line1: "test",
city: "San Francisco",
},
}
)
stub_request(:post, "#{Stripe.api_base}/v1/accounts/acct_123")
.with(body: { company: { address: { line1: "Test2", city: "" } } })
.to_return(body: JSON.generate("id" => "my_id"))
acct.company.address = { line1: "Test2" }
acct.save
end
should "correctly handle array setting" do
acct = Stripe::Account.construct_from(id: "myid",
legal_entity: {})
stub_request(:post, "#{Stripe.api_base}/v1/accounts/myid")
.with(body: { legal_entity: { additional_owners: [{ first_name: "Bob" }] } })
.to_return(body: JSON.generate("id" => "myid"))
acct.legal_entity.additional_owners = [{ first_name: "Bob" }]
acct.save
end
should "correctly handle array insertion" do
acct = Stripe::Account.construct_from(id: "myid",
legal_entity: {
additional_owners: [],
})
# Note that this isn't a perfect check because we're using webmock's
# data decoding, which isn't aware of the Stripe array encoding that we
# use here.
stub_request(:post, "#{Stripe.api_base}/v1/accounts/myid")
.with(body: { legal_entity: { additional_owners: [{ first_name: "Bob" }] } })
.to_return(body: JSON.generate("id" => "myid"))
acct.legal_entity.additional_owners << { first_name: "Bob" }
acct.save
end
should "correctly handle array updates" do
acct = Stripe::Account.construct_from(id: "myid",
legal_entity: {
additional_owners: [{ first_name: "Bob" }, { first_name: "Jane" }],
})
# Note that this isn't a perfect check because we're using webmock's
# data decoding, which isn't aware of the Stripe array encoding that we
# use here.
stub_request(:post, "#{Stripe.api_base}/v1/accounts/myid")
.with(body: { legal_entity: { additional_owners: [{ first_name: "Janet" }] } })
.to_return(body: JSON.generate("id" => "myid"))
acct.legal_entity.additional_owners[1].first_name = "Janet"
acct.save
end
should "correctly handle array noops" do
acct = Stripe::Account.construct_from(id: "myid",
legal_entity: {
additional_owners: [{ first_name: "Bob" }],
},
currencies_supported: %w[usd cad])
stub_request(:post, "#{Stripe.api_base}/v1/accounts/myid")
.with(body: {})
.to_return(body: JSON.generate("id" => "myid"))
acct.save
end
should "correctly handle hash noops" do
acct = Stripe::Account.construct_from(id: "myid",
legal_entity: {
address: { line1: "1 Two Three" },
})
stub_request(:post, "#{Stripe.api_base}/v1/accounts/myid")
.with(body: {})
.to_return(body: JSON.generate("id" => "myid"))
acct.save
end
should "should create a new resource when an object without an id is saved" do
account = Stripe::Account.construct_from(id: nil,
display_name: nil)
stub_request(:post, "#{Stripe.api_base}/v1/accounts")
.with(body: { display_name: "stripe" })
.to_return(body: JSON.generate("id" => "acct_123"))
account.display_name = "stripe"
account.save
end
should "set attributes as part of save" do
account = Stripe::Account.construct_from(id: nil,
display_name: nil)
stub_request(:post, "#{Stripe.api_base}/v1/accounts")
.with(body: { display_name: "stripe", metadata: { key: "value" } })
.to_return(body: JSON.generate("id" => "acct_123"))
account.save(display_name: "stripe", metadata: { key: "value" })
end
end
context "#request_stripe_object" do
class HelloTestAPIResource < APIResource
OBJECT_NAME = "hello"
def say_hello(params = {}, opts = {})
request_stripe_object(
method: :post,
path: resource_url + "/say",
params: params,
opts: opts
)
end
end
setup do
Util.instance_variable_set(
:@object_classes,
Stripe::ObjectTypes.object_names_to_classes.merge(
"hello" => HelloTestAPIResource
)
)
end
teardown do
Util.class.instance_variable_set(:@object_classes, Stripe::ObjectTypes.object_names_to_classes)
end
should "make requests appropriately" do
stub_request(:post, "#{Stripe.api_base}/v1/hellos/hi_123/say")
.with(body: { foo: "bar" }, headers: { "Stripe-Account" => "acct_hi" })
.to_return(body: JSON.generate("object" => "hello"))
hello = HelloTestAPIResource.new(id: "hi_123")
hello.say_hello({ foo: "bar" }, stripe_account: "acct_hi")
end
should "update attributes in-place when it returns the same thing" do
stub_request(:post, "#{Stripe.api_base}/v1/hellos/hi_123/say")
.to_return(body: JSON.generate("object" => "hello", "additional" => "attribute"))
hello = HelloTestAPIResource.new(id: "hi_123")
hello.unsaved = "a value"
new_hello = hello.say_hello
# Doesn't matter if you use the return variable or the instance.
assert_equal(hello, new_hello)
# It updates new attributes in-place.
assert_equal("attribute", hello.additional)
# It removes unsaved attributes, but at least lets you know about them.
e = assert_raises(NoMethodError) { hello.unsaved }
assert_match("The 'unsaved' attribute was set in the past", e.message)
end
should "instantiate a new object of the appropriate class when it is different than the host class" do
stub_request(:post, "#{Stripe.api_base}/v1/hellos/hi_123/say")
.to_return(body: JSON.generate("object" => "goodbye", "additional" => "attribute"))
hello = HelloTestAPIResource.new(id: "hi_123")
hello.unsaved = "a value"
new_goodbye = hello.say_hello
# The returned value and the instance are different objects.
refute_equal(new_goodbye, hello)
# The returned value has stuff from the server.
assert_equal("attribute", new_goodbye.additional)
assert_equal("goodbye", new_goodbye.object)
# You instance doesn't have stuff from the server.
e = assert_raises(NoMethodError) { hello.additional }
refute_match(/was set in the past/, e.message)
# The instance preserves unset attributes on the original instance (not sure this is good behavior?)
assert_equal("a value", hello.unsaved)
end
end
@@fixtures = {} # rubocop:disable Style/ClassVars
setup do
if @@fixtures.empty?
cache_fixture(:charge) do
Charge.retrieve("ch_123")
end
cache_fixture(:customer) do
Customer.retrieve("cus_123")
end
end
end
private def charge_fixture
@@fixtures[:charge]
end
private def customer_fixture
@@fixtures[:customer]
end
# Expects to retrieve a fixture from stripe-mock (an API call should be
# included in the block to yield to) and does very simple memoization.
private def cache_fixture(key)
return @@fixtures[key] if @@fixtures.key?(key)
obj = yield
@@fixtures[key] = obj.instance_variable_get(:@values).freeze
@@fixtures[key]
end
end
end