New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass params into logger.{info,debug} #913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closing this until we are able to get some user feedback, (maybe on #776). We think this solves this use case, but we want to be sure. |
This LGTM. |
pakrym-stripe
approved these changes
Jan 30, 2023
this change probably causes #922 |
richardm-stripe
added a commit
that referenced
this pull request
Feb 6, 2023
This reverts commit c45cc1d.
richardm-stripe
added a commit
that referenced
this pull request
Feb 6, 2023
richardm-stripe
added a commit
that referenced
this pull request
Feb 24, 2023
* Pass params into logger.{info,debug} (#913) * Pass params into logger.{info,debug} * API Updates (#920) * Codegen for openapi v223 * Bump version to 5.1.0 * Revert "Pass params into logger.{info,debug} (#913)" (#923) This reverts commit c45cc1d. * Bump version to 5.1.1 * Codegen for openapi v225 * Bump version to 5.2.0 * Set version to 5.2.0 to simplify merge * Reset version to 5.2.0b1 * Codegen for openapi v232 * Format --------- Co-authored-by: Annie Li <anniel@stripe.com> Co-authored-by: anniel-stripe <97691964+anniel-stripe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Causes
util.log_info
andutil.log_debug
to pass more information into the underlying pythonlogger.info
andlogger.debug
methods.By default, this will do nothing, but if you define and attach your own
logger.Formatter
you will be able to access this information on.args
property on the argument to theformat
method.Fixes #776.