Feature request: Honor order of metadata keys

[dramirez-tc]

Would it be possible to honor the order of metadata keys? We rely on a lot of metadata and the ordering is important. In our case alphabetical. An OrderedDict is passed to Charge.create() but it looks like the ordering gets lost in the api_requestor.py:_encode_nested_dict() func. Perhaps instead of

d {}

from collections import OrderedDict
d = OrderedDict()

Maybe there's a more clever way to handle that.

[ob-stripe]

Hi @dramirez-tc.

I would personally advise against relying on a specific order for metadata keys. Stripe's API makes no guarantee around key order, and if I'm not mistaken returns metadata keys in alphabetical order, not insertion order. In any case, the ordering is more of an implementation detail than a formal contract.

Nevertheless, I've opened a PR for this (#614) as I think maintaining order in API requests and responses makes the client library more consistent and easier to reason around.

[ob-stripe]

Fixed in 2.36.2.

[dramirez-tc]

Thank you so much! It's so refreshing to work for a company that really listens! Mwah!