Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Updates #1383

Merged
merged 4 commits into from Mar 28, 2022
Merged

API Updates #1383

merged 4 commits into from Mar 28, 2022

Conversation

pakrym-stripe
Copy link
Contributor

@pakrym-stripe pakrym-stripe commented Mar 28, 2022 •
edited

Codegen for openapi 2956fca.
r? @yejia-stripe
cc @stripe/api-libraries

Changelog

  • Add support for Search API
    • Add support for search method on resources Charge, Customer, Invoice, PaymentIntent, Price, Product, and Subscription

yejia-stripe
yejia-stripe approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@yejia-stripe yejia-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

dcr-stripe
dcr-stripe suggested changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add unit tests + total_count to the result type.

@pakrym-stripe
Copy link
Contributor Author

PTAL @dcr-stripe ?

dcr-stripe
dcr-stripe approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pakrym-stripe pakrym-stripe merged commit 19d0e34 into master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcr-stripe dcr-stripe dcr-stripe approved these changes

@yejia-stripe yejia-stripe yejia-stripe approved these changes

Assignees

@pakrym-stripe pakrym-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pakrym-stripe @dcr-stripe @yejia-stripe