Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish specifying the Financial Connections Account type #354

Merged

Conversation

bcobb-stripe
Copy link
Contributor

Summary & motivation

  • For reasons I do not remember (possibly for no good reason), Add Financial Connections types #338 didn't
    contain type definitions for the entire Financial Connections Account
    resource. This PR adds them.
  • Additionally, converts the category type from a string to an enum of
    strings

Testing & documentation

  • Extends the valid.ts test to test various attributes, and to demonstrate
    the behavior of cash vs credit balance types.

- adds missing attributes
- converts the `category` type from a `string` to an enum
Copy link
Contributor

@martinalong-stripe martinalong-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll go ahead and merge it

@martinalong-stripe martinalong-stripe merged commit 0a37f08 into master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants