Add address element types #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| update(options: Partial<StripeAddressElementOptions>): StripeAddressElement; | ||
| }; | ||
|
|
||
| export interface ContactOption { |
There was a problem hiding this comment.
Question: should we wait until API review has been gaveled for GA to release this? What is the significance of adding Option to the name instead of just Contact?
There was a problem hiding this comment.
good question! I think it should be fine for us to add it now since we want beta users to test it out without running into type error and the whole AE is marked as "beta access" only. I was following the convention we have to append a option after the type name, such as FieldOption.
cyuen-stripe
previously approved these changes
Sep 21, 2022
cyuen-stripe
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
Added types for
addresselement and markedshippingAddressas deprecated.Testing & documentation
Added invalid and valid tests