Add defaultValues to StripePaymentElementOptions interface
#332
Conversation
|
|
| @@ -266,6 +266,21 @@ const afterpayClearpayMessageElement = elements.create( | |||
| ); | |||
|
|
|||
| const paymentElement: StripePaymentElement = elements.create('payment', { | |||
| defaultValues: { | |||
There was a problem hiding this comment.
I'm not sure how exhaustive I should be for the tests. Please let me know if anything can be added!
starsirius
changed the title
defaultValues to StripePaymentElementOptionsdefaultValues to StripePaymentElementOptions interface
| address?: | ||
| { | ||
| country?: string; | ||
| postalCode?: string; |
There was a problem hiding this comment.
This should be postal_code instead of postalCode (doc)!
There was a problem hiding this comment.
@jackieosborn-stripe Thank you for the quick review and nice catch!
And just to surface it, it seems inconsistent, for example with the postalCode in the fields option.
There was a problem hiding this comment.
Updated it in 2ad16db.
There was a problem hiding this comment.
Thanks for bringing it up - we're aware of the inconsistencies 🙂
There was a problem hiding this comment.
Awesome! Thank you! Looking forward to getting this released! 🎉
tests/types/src/valid.ts
Outdated
| city: 'South San Francisco', | ||
| state: 'CA', | ||
| country: 'US', | ||
| postalCode: '94080' |
There was a problem hiding this comment.
And then same here :)
Summary & motivation
We ran into typescript error when using the
defaultValuesoption in Payment Element. This adds it toStripePaymentElementOptionsinterface.Testing & documentation
I wrote unit tests.