Remove CustomerSession#StripeApiProxy #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshafrir-stripe
force-pushed
the
remove-customer-session-proxy
branch
from
794658a
to
0d1ee76
Compare
jemerick-stripe
approved these changes
Apr 9, 2019
This interface was only used for testing and added complexity to the logic of `CustomerSession`. Refactor `CustomerSession` to allow for passing in mock objects to verify interactions.
mshafrir-stripe
force-pushed
the
remove-customer-session-proxy
branch
from
0d1ee76
to
b084f50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This interface was only used for testing and added complexity to the
logic of
CustomerSession. RefactorCustomerSessionto allow forpassing in mock objects to verify interactions.
Motivation
Simplify
CustomerSessionTesting
Updated tests and manually tested