Use Application context instead of Activity in Stripe.java #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** The crux of this change is making Stripe constructors use Application context instead of Activity context. This change also marks instance variables as `final` and `@NonNull` where applicable. **Motivation** Relying on activity context for asynchronous tasks can lead to memory leaks. We would only need an Activity context to access the UI, which is not the case for any of the logic in Stripe.java. **Testing** Interacted with all of the screens in the example app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The crux of this change is making Stripe constructors use
Application context instead of Activity context.
This change also marks instance variables as
finaland@NonNullwhere applicable.Motivation
Relying on activity context for asynchronous tasks can
lead to memory leaks. We would only need an Activity
context to access the UI, which is not the case for any
of the logic in Stripe.java.
Testing
Interacted with all of the screens in the example app.