Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] update fileprovider name #5474

Merged
merged 2 commits into from Aug 29, 2022
Merged

Conversation

ccen-stripe
Copy link
Collaborator

Summary

Change the file provider name to be Stipe Identity specific to avoid potential conflict with other libraries.

Motivation

Other SDK might also use ${packagename}.fileprovider as the fileprovider name, change the suffix would avoid the naming conflict.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

[Fixed] - Fixed a potential conflict when other libararies also define a file provider.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2022

Diffuse output:

OLD: identity-example-release-base.apk (signature: none)
NEW: identity-example-release-pr.apk (signature: none)

          │         compressed          │         uncompressed          
          ├──────────┬──────────┬───────┼───────────┬───────────┬───────
 APK      │ old      │ new      │ diff  │ old       │ new       │ diff  
──────────┼──────────┼──────────┼───────┼───────────┼───────────┼───────
      dex │  6.3 MiB │  6.3 MiB │ -43 B │  17.8 MiB │  17.8 MiB │ +12 B 
     arsc │  1.1 MiB │  1.1 MiB │   0 B │   1.1 MiB │   1.1 MiB │   0 B 
 manifest │  1.9 KiB │  1.9 KiB │  +7 B │   6.6 KiB │   6.6 KiB │ +28 B 
      res │  385 KiB │  385 KiB │   0 B │ 589.2 KiB │ 589.2 KiB │   0 B 
   native │  5.7 MiB │  5.7 MiB │   0 B │  14.4 MiB │  14.4 MiB │   0 B 
    asset │  9.3 KiB │  9.3 KiB │   0 B │     9 KiB │     9 KiB │   0 B 
    other │ 28.2 KiB │ 28.2 KiB │   0 B │  27.1 KiB │  27.1 KiB │   0 B 
──────────┼──────────┼──────────┼───────┼───────────┼───────────┼───────
    total │ 13.5 MiB │ 13.5 MiB │ -36 B │  33.8 MiB │  33.8 MiB │ +40 B 

         │          raw           │           unique            
         ├────────┬────────┬──────┼────────┬────────┬───────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff      
─────────┼────────┼────────┼──────┼────────┼────────┼───────────
   files │      2 │      2 │    0 │        │        │           
 strings │ 116682 │ 116682 │    0 │ 106862 │ 106862 │ 0 (+1 -1) 
   types │  16787 │  16787 │    0 │  15736 │  15736 │ 0 (+0 -0) 
 classes │  14126 │  14126 │    0 │  14126 │  14126 │ 0 (+0 -0) 
 methods │ 107747 │ 107747 │    0 │ 104758 │ 104758 │ 0 (+0 -0) 
  fields │  76627 │  76627 │    0 │  76383 │  76383 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  259 │  259 │  0   
 entries │ 4760 │ 4760 │  0
APK
   compressed    │  uncompressed   │                       
─────────┬───────┼─────────┬───────┤                       
 size    │ diff  │ size    │ diff  │ path                  
─────────┼───────┼─────────┼───────┼───────────────────────
 2.3 MiB │ -43 B │ 6.9 MiB │ +12 B │ ∆ classes2.dex        
 1.9 KiB │  +7 B │ 6.6 KiB │ +28 B │ ∆ AndroidManifest.xml 
─────────┼───────┼─────────┼───────┼───────────────────────
 2.3 MiB │ -36 B │ 6.9 MiB │ +40 B │ (total)
MANIFEST
@@ -65,3 +65,3 @@
     <provider
-        android:authorities=com.stripe.android.identity.example.theme1.fileprovider
+        android:authorities=com.stripe.android.identity.example.theme1.StripeIdentityFileprovider
         android:exported=false
DEX
STRINGS:

   old    │ new    │ diff      
  ────────┼────────┼───────────
   106862 │ 106862 │ 0 (+1 -1) 
  + .StripeIdentityFileprovider
  
  - .fileprovider

@ccen-stripe ccen-stripe merged commit d455d48 into master Aug 29, 2022
@ccen-stripe ccen-stripe deleted the ccen/fileProviderFix branch August 29, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants