Add country code to PaymentIntent and SetupIntent
#5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diffuse output: APKDEX |
tillh-stripe
requested review from
brnunes-stripe,
michelleb-stripe,
ccen-stripe and
jameswoo-stripe
as code owners
|
@jameswoo-stripe You’re right — it’s not a public field, but something we fetch via Since it’s not a field in the public API of a payment/setup intent, should I make this an internal field? |
|
Yea, that makes more sense to be internal. Also, let's add some tests to test the parsing using fixtures. |
brnunes-stripe
suggested changes
Aug 26, 2022
payments-core/src/main/java/com/stripe/android/model/StripeIntent.kt
Outdated
Show resolved
Hide resolved
Having the country code as a library-internal property in StripeIntent isn't easy right now. We're adding it as separate properties in SetupIntent and PaymentIntent for now, before we think about ways to refactor StripeIntent.
jameswoo-stripe
previously approved these changes
Aug 26, 2022
|
We chatted about this on Zoom. TL;DR: Adding |
jameswoo-stripe
approved these changes
Aug 26, 2022
brnunes-stripe
approved these changes
Aug 26, 2022
tillh-stripe
changed the title
StripeIntentPaymentIntent and SetupIntent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the country code to
StripeIntent.Motivation
This will be needed for the name collection in Link.
Testing
Screenshots
🙅
Changelog
Nothing to add.