Add logout menu in Link wallet #5470

tillh-stripe · 2022-08-26T13:54:50Z

Summary

This pull request adds a logout menu to the Link wallet’s navigation bar. When pressed, we close Link and log out the user.

The other change to Link’s behavior, namely that Pay another way no longer logs out the user, is coming in a separate pull request.

Motivation

Offer users a way to log out.

Testing

Added tests
Modified tests
Manually verified

Screen recording

device-2022-08-26-103554.mp4

Changelog

Nothing to add.

github-actions · 2022-08-26T14:05:42Z

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │            compressed            │           uncompressed            
          ├───────────┬───────────┬──────────┼───────────┬───────────┬───────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff      
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼───────────
      dex │  15.4 MiB │  15.4 MiB │ +2.6 KiB │    52 MiB │    52 MiB │ +12.9 KiB 
     arsc │   1.8 MiB │   1.8 MiB │   +1 KiB │   1.8 MiB │   1.8 MiB │    +1 KiB 
 manifest │     4 KiB │     4 KiB │      0 B │  18.5 KiB │  18.5 KiB │       0 B 
      res │ 874.5 KiB │ 874.5 KiB │     -2 B │   1.4 MiB │   1.4 MiB │       0 B 
   native │   2.5 MiB │   2.5 MiB │      0 B │   5.9 MiB │   5.9 MiB │       0 B 
    asset │     3 MiB │     3 MiB │     +4 B │     3 MiB │     3 MiB │      +4 B 
    other │  81.7 KiB │  81.7 KiB │      0 B │ 155.6 KiB │ 155.6 KiB │       0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼───────────
    total │  23.6 MiB │  23.6 MiB │ +3.6 KiB │  64.2 MiB │  64.2 MiB │ +13.9 KiB 

         │          raw           │              unique              
         ├────────┬────────┬──────┼────────┬────────┬────────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff           
─────────┼────────┼────────┼──────┼────────┼────────┼────────────────
   files │      4 │      4 │    0 │        │        │                
 strings │ 251290 │ 251341 │  +51 │ 214285 │ 214331 │ +46 (+88 -42)  
   types │  44367 │  44393 │  +26 │  40731 │  40756 │ +25 (+40 -15)  
 classes │  37928 │  37952 │  +24 │  37928 │  37952 │ +24 (+39 -15)  
 methods │ 221861 │ 221951 │  +90 │ 213861 │ 213950 │ +89 (+155 -66) 
  fields │ 163095 │ 163144 │  +49 │ 162052 │ 162100 │ +48 (+83 -35)  

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  292 │  292 │  0         
 entries │ 6235 │ 6237 │ +2 (+2 -0)

APK

     compressed      │     uncompressed     │                               
──────────┬──────────┼──────────┬───────────┤                               
 size     │ diff     │ size     │ diff      │ path                          
──────────┼──────────┼──────────┼───────────┼───────────────────────────────
  2.3 MiB │ +2.5 KiB │  6.9 MiB │ +12.9 KiB │ ∆ classes3.dex                
  1.8 MiB │   +1 KiB │  1.8 MiB │    +1 KiB │ ∆ resources.arsc              
  3.2 MiB │    +32 B │  9.1 MiB │       0 B │ ∆ classes4.dex                
  8.7 KiB │     +4 B │  8.6 KiB │      +4 B │ ∆ assets/dexopt/baseline.prof 
  3.1 MiB │     +4 B │  8.3 MiB │       0 B │ ∆ classes2.dex                
    997 B │     -2 B │  2.8 KiB │       0 B │ ∆ res/AE.xml                  
    740 B │     -2 B │  1.4 KiB │       0 B │ ∆ res/Am.xml                  
    767 B │     +2 B │  1.5 KiB │       0 B │ ∆ res/M6.xml                  
  6.8 MiB │     +1 B │ 27.7 MiB │       0 B │ ∆ classes.dex                 
    682 B │     +1 B │  1.3 KiB │       0 B │ ∆ res/-G.xml                  
    848 B │     +1 B │  1.8 KiB │       0 B │ ∆ res/0M.xml                  
  1.1 KiB │     -1 B │  2.9 KiB │       0 B │ ∆ res/5d.xml                  
  1.1 KiB │     +1 B │  3.1 KiB │       0 B │ ∆ res/Cm.xml                  
  1.1 KiB │     -1 B │  3.1 KiB │       0 B │ ∆ res/FR.xml                  
  1.5 KiB │     -1 B │  4.9 KiB │       0 B │ ∆ res/Gh.xml                  
  1.2 KiB │     +1 B │  3.7 KiB │       0 B │ ∆ res/Q0.xml                  
  1,008 B │     -1 B │  2.8 KiB │       0 B │ ∆ res/R5.xml                  
  1.5 KiB │     -1 B │  5.2 KiB │       0 B │ ∆ res/WO.xml                  
    758 B │     +1 B │  1.4 KiB │       0 B │ ∆ res/WZ.xml                  
    533 B │     -1 B │    984 B │       0 B │ ∆ res/aR.xml                  
    501 B │     +1 B │    984 B │       0 B │ ∆ res/cS.xml                  
    618 B │     -1 B │  1.1 KiB │       0 B │ ∆ res/ib1.xml                 
    1 KiB │     -1 B │  2.6 KiB │       0 B │ ∆ res/j9.xml                  
    803 B │     +1 B │  1.7 KiB │       0 B │ ∆ res/wf.xml                  
    809 B │     +1 B │  2.3 KiB │       0 B │ ∆ res/yn.xml                  
──────────┼──────────┼──────────┼───────────┼───────────────────────────────
 17.2 MiB │ +3.6 KiB │ 53.8 MiB │ +13.9 KiB │ (total)

DEX

STRINGS:

   old    │ new    │ diff          
  ────────┼────────┼───────────────
   214285 │ 214331 │ +46 (+88 -42) 
  + �
  
  ���
  
  ���
  ����)���0�2��������0�0�2��������0�0�H�¢����¨��
  +  
  ���
  ��
  
  ���
  
  ���
  ���
  ���
  �������2�0�B)��������0�������0�������0���������0�¢���	J	����0�HÆ�J	����0�HÆ�J	����0�HÆ�J�������0�HÆ�J3����02�������0�2�������0�2�������0�2
  ��������0�HÆ�J�����0�2�������0�HÖ�J	����0�HÖ�J	����0�HÖ�R�������0�¢��
  ���
  ��R�����0�¢��
  ����
  R�����0�¢��
  ������R�����0�¢��
  ������¨��
  + 
  ���
  ���
  
  ���
  
  ���
  ���
  ���
  ���
  �0�2�0�:�
  �B���������0���������0�¢����R�����0�X��¢��
  ������R�����0�X��¢��
  �����	���
  ¨��
  + 0
  
  ���
  ���
  ���
  
  ���
  ���
  ���
  ���
  ���
  ���
  ���
  ����
  ���0�H�¢�����c���0�2�����0�2��������0�0�2��������0�0�20���,�� ����0
  ����0���0	j����¢���¢���
  ����0�0	H�¢�����
  ����0�H�¢�����
  ����0�H�¢�����
  ����0�H�¢����¨��
  + N
  ���
  ���
  
  ���
  
  ���
  
  ���
  
  ���
  ���
  ���
  ���
  ���
  ���
  ���
  ���
  
  ���
  ���
  ���
  �����2�0�:�_B'��������0�������0�������0�������0	¢���
  J�����0�2�����0�H�J�����0�J�����0�J�� ��0�2��!��0J��#��0�R�����0	X��¢��
  R�����0X�.¢��
  ���
  �������R����
  ������0�0�¢��
  ������R�����0�¢��
  ������R�����0�¢��
  ������¨�%
  + _onLogout
  + _onLogoutClick
  + (IZZLjava/lang/String;)V
  + (Lcom/stripe/android/link/ui/LinkAppBarState;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Landroidx/compose/runtime/Composer;I)V
  + (Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function0;Landroidx/compose/runtime/Composer;I)V
  + , showHeader=
  + , showOverflowMenu=
  + LIZZL
  + LLIZZLIL
  + Lcom/stripe/android/link/LinkActivity_onCreate_1_2_1_1_3_1;
  + Lcom/stripe/android/link/LinkActivity_onCreate_1_2_1_1_3;
  + Lcom/stripe/android/link/LinkActivity_onCreate_1_2_1_1_4_1;
  + Lcom/stripe/android/link/LinkActivity_onCreate_1_2_1_1_4_2;
  + Lcom/stripe/android/link/LinkActivity_onCreate_1_2_1_1_4_3;
  + Lcom/stripe/android/link/LinkActivity_onCreate_1_2_1_1_4_4_1_1_1;
  + Lcom/stripe/android/link/LinkActivity_onCreate_1_2_1_1_4_4_1_1;
  + Lcom/stripe/android/link/LinkActivity_onCreate_1_2_1_1_4_4;
  + Lcom/stripe/android/link/LinkActivity_onCreate_1_2_1_1_4_5;
  + Lcom/stripe/android/link/LinkActivity_onCreate_1_2_1_1_4_6;
  + Lcom/stripe/android/link/LinkActivity_onCreate_1_2_1_1_4_7;
  + Lcom/stripe/android/link/LinkActivity_onCreate_1_2_1_1_4_8;
  + Lcom/stripe/android/link/LinkActivity_onCreate_1_2_1_1_4;
  + Lcom/stripe/android/link/ui/ComposableSingletons_LinkAppBarKt_lambda-2_1_1;
  + Lcom/stripe/android/link/ui/ComposableSingletons_LinkAppBarKt_lambda-2_1_2;
  + Lcom/stripe/android/link/ui/ComposableSingletons_LinkAppBarKt_lambda-2_1_3;
  + Lcom/stripe/android/link/ui/ComposableSingletons_LinkAppBarKt_lambda-4_1_1;
  + Lcom/stripe/android/link/ui/ComposableSingletons_LinkAppBarKt_lambda-4_1_2;
  + Lcom/stripe/android/link/ui/ComposableSingletons_LinkAppBarKt_lambda-4_1_3;
  + Lcom/stripe/android/link/ui/ComposableSingletons_LinkAppBarKt_lambda-6_1_1;
  + Lcom/stripe/android/link/ui/ComposableSingletons_LinkAppBarKt_lambda-6_1_2;
  + Lcom/stripe/android/link/ui/ComposableSingletons_LinkAppBarKt_lambda-6_1_3;
  + Lcom/stripe/android/link/ui/ComposableSingletons_LinkAppBarKt_lambda-8_1_1;
  + Lcom/stripe/android/link/ui/ComposableSingletons_LinkAppBarKt_lambda-8_1_2;
  + Lcom/stripe/android/link/ui/ComposableSingletons_LinkAppBarKt_lambda-8_1_3;
  + Lcom/stripe/android/link/ui/ComposableSingletons_LinkAppBarKt_lambda-9_1;
  + Lcom/stripe/android/link/ui/LinkAppBarKt_LinkAppBar_1_3_1_1_1_1;
  + Lcom/stripe/android/link/ui/LinkAppBarKt_LinkAppBar_1_3_1_1_2_1;
  + Lcom/stripe/android/link/ui/LinkAppBarKt_LinkAppBar_1_3_1_1;
  + Lcom/stripe/android/link/ui/LinkAppBarKt_LinkAppBar_1_3_1;
  + Lcom/stripe/android/link/ui/LinkLogoutMenuItem_Cancel;
  + Lcom/stripe/android/link/ui/LinkLogoutMenuItem_Logout;
  + Lcom/stripe/android/link/ui/LinkLogoutMenuItem;
  + Lcom/stripe/android/link/ui/LinkLogoutSheetKt_LinkLogoutSheet_1_1;
  + Lcom/stripe/android/link/ui/LinkLogoutSheetKt_LinkLogoutSheet_2;
  + Lcom/stripe/android/link/ui/LinkLogoutSheetKt;
  + Lcom/stripe/android/link/ui/verification/VerificationDialogKt_LinkVerificationDialog_1_1_1_1_1_1_1_1;
  + Lcom/stripe/android/link/ui/verification/VerificationDialogKt_LinkVerificationDialog_1_1_1_1_1_1_1_2;
  + Lcom/stripe/android/link/ui/verifica
...✂

ARSC

ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6235 │ 6237 │ +2 (+2 -0) 
  + string/log_out
  + string/menu

tillh-stripe mentioned this pull request Aug 26, 2022

Add Link logout menu and tweak close behavior #5465

Closed

3 tasks

tillh-stripe force-pushed the tillh/link-logout-bottom-sheet branch 2 times, most recently from 738b018 to 001aecf Compare August 26, 2022 14:55

tillh-stripe marked this pull request as ready for review August 26, 2022 14:56

tillh-stripe requested review from brnunes-stripe, michelleb-stripe and jameswoo-stripe as code owners August 26, 2022 14:56

brnunes-stripe previously approved these changes Aug 26, 2022

View reviewed changes

stripe-ci assigned tillh-stripe Aug 26, 2022

tillh-stripe dismissed brnunes-stripe’s stale review via c570199 August 29, 2022 14:13

tillh-stripe force-pushed the tillh/link-logout-bottom-sheet branch 2 times, most recently from 0f2cb79 to eb81a11 Compare August 29, 2022 14:30

tillh-stripe requested a review from brnunes-stripe August 29, 2022 16:29

brnunes-stripe previously approved these changes Aug 29, 2022

View reviewed changes

brnunes-stripe assigned brnunes-stripe and unassigned brnunes-stripe Aug 29, 2022

tillh-stripe added 4 commits August 29, 2022 15:01

Add logout menu in Link wallet

7d76371

Add tests

e351b11

Update API

be77b0f

Fix lint issue

79b7e37

tillh-stripe dismissed brnunes-stripe’s stale review via 50d3500 August 29, 2022 19:03

tillh-stripe force-pushed the tillh/link-logout-bottom-sheet branch from 10576d7 to 50d3500 Compare August 29, 2022 19:03

tillh-stripe assigned brnunes-stripe and unassigned tillh-stripe Aug 29, 2022

tillh-stripe requested a review from brnunes-stripe August 29, 2022 19:03

Fix rebase issue

a7096c2

tillh-stripe force-pushed the tillh/link-logout-bottom-sheet branch from 50d3500 to a7096c2 Compare August 29, 2022 19:17

brnunes-stripe approved these changes Aug 29, 2022

View reviewed changes

stripe-ci assigned tillh-stripe Aug 29, 2022

stripe-ci unassigned brnunes-stripe Aug 29, 2022

tillh-stripe merged commit 435d2ba into master Aug 29, 2022

tillh-stripe deleted the tillh/link-logout-bottom-sheet branch August 29, 2022 19:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add logout menu in Link wallet #5470

Add logout menu in Link wallet #5470

tillh-stripe commented Aug 26, 2022 •

edited

github-actions bot commented Aug 26, 2022 •

edited

Add logout menu in Link wallet #5470

Add logout menu in Link wallet #5470

Conversation

tillh-stripe commented Aug 26, 2022 • edited

Summary

Motivation

Testing

Screen recording

Changelog

github-actions bot commented Aug 26, 2022 • edited

tillh-stripe commented Aug 26, 2022 •

edited

github-actions bot commented Aug 26, 2022 •

edited