Refactoring to support Bank Accounts in Link #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Diffuse output: APKDEXARSC |
brnunes-stripe
requested review from
michelleb-stripe,
tillh-stripe,
jameswoo-stripe and
ccen-stripe
as code owners
link/src/main/java/com/stripe/android/link/ui/paymentmethod/SupportedPaymentMethod.kt
Outdated
Show resolved
Hide resolved
link/src/main/java/com/stripe/android/link/ui/verification/VerificationViewModel.kt
Outdated
Show resolved
Hide resolved
tillh-stripe
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PrimaryButtonreceive two optional icons, for the left and right, in order to show the "Add bank account" icon on the left.Navigator.backNavigationEnabledtouserNavigationEnabled, blocking only navigation initiated by user interaction.SupportedPaymentMethod, removing methods that were generalizing how we create the different PaymentDetails types. In reality the creation is too different, and these methods were only relevant for Card.CardEditViewModel.ResultintoPaymentDetailsResultto be used by bothCardEditViewModelandPaymentMethodViewModelwhen connecting a new bank account.LinkAccountManager.createPaymentDetailstocreateCardPaymentDetails, used only for cards. AddcreateBankAccountPaymentDetailsfor bank accounts.Motivation
Link instant debits.
Testing