Fix issue with country dropdown not updating country #5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswoo-stripe
requested review from
brnunes-stripe and
michelleb-stripe
as code owners
|
Diffuse output: APKDEX |
tillh-stripe
previously approved these changes
Aug 22, 2022
| @@ -68,6 +68,12 @@ open class AddressElement constructor( | |||
| addressRepository.get(countryCode) | |||
| ?: emptyList() | |||
| } | |||
| .map { fields -> | |||
There was a problem hiding this comment.
Instead of mapping, you could use an onEach { … } here. I find it shows the side-effect-y intention better.
Comment on lines
152
to
154
| addressElement.fields.first().map { | ||
| it.getFormFieldValueFlow().first()[0].second.value | ||
| }.first() |
There was a problem hiding this comment.
Since you end up just using the first element from the mapped list, you could avoid mapping the entire list and just access the first element directly.
tillh-stripe
approved these changes
Aug 22, 2022
jameswoo-stripe
deleted the
jameswoo/shipping-address-element-fix-country-dropdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue where the country dropdown was not updating correctly. This was broken in this previous PR
To test the change, use the payment sheet playground and play around with different customer types, default billing address enabled/disabled, and update the country dropdown to different countries. Make sure that the fields get updated, for example, US should show zip code, Canada should show postal code, other countries may not have other fields for billing address.
Testing
Screenshots