Fix cut-off payment methods carousel in payment sheet #5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/payments-list-padding-fix
branch
from
a70aab9
to
de53098
Compare
tillh-stripe
force-pushed
the
tillh/payments-list-padding-fix
branch
from
de53098
to
03f61e8
Compare
tillh-stripe
commented
Aug 19, 2022
| @@ -42,10 +44,10 @@ internal fun PaymentMethodsUI( | |||
| paymentMethods: List<SupportedPaymentMethod>, | |||
| selectedIndex: Int, | |||
| isEnabled: Boolean, | |||
| onItemSelectedListener: (SupportedPaymentMethod) -> Unit | |||
| onItemSelectedListener: (SupportedPaymentMethod) -> Unit, | |||
| state: LazyListState = rememberLazyListState() | |||
There was a problem hiding this comment.
Pulling this out so that I can pass in a specific firstVisibleItemIndex in tests.
There was a problem hiding this comment.
Won't this code below already scroll to have the selected item as the first visible?
LaunchedEffect(selectedIndex) {
state.scrollToItem(selectedIndex, 0)
}
There was a problem hiding this comment.
Yep, you’re right. I initially thought that the LaunchedEffect didn’t work properly in the test, but turns out it was because I also passed a wrong selectedIndex in my test at the same time.
tillh-stripe
requested review from
brnunes-stripe,
michelleb-stripe and
jameswoo-stripe
as code owners
brnunes-stripe
suggested changes
Aug 19, 2022
| @@ -42,10 +44,10 @@ internal fun PaymentMethodsUI( | |||
| paymentMethods: List<SupportedPaymentMethod>, | |||
| selectedIndex: Int, | |||
| isEnabled: Boolean, | |||
| onItemSelectedListener: (SupportedPaymentMethod) -> Unit | |||
| onItemSelectedListener: (SupportedPaymentMethod) -> Unit, | |||
| state: LazyListState = rememberLazyListState() | |||
There was a problem hiding this comment.
Won't this code below already scroll to have the selected item as the first visible?
LaunchedEffect(selectedIndex) {
state.scrollToItem(selectedIndex, 0)
}
paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentMethodsUI.kt
Outdated
Show resolved
Hide resolved
tillh-stripe
force-pushed
the
tillh/payments-list-padding-fix
branch
from
03f61e8
to
991cef3
Compare
tillh-stripe
force-pushed
the
tillh/payments-list-padding-fix
branch
from
991cef3
to
d5b71c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request switches to using
contentPaddingfor the payment methods carousel, which fixes a UX issue where the list was cut off prematurely at the start when scrolling.Motivation
UX polish.
Testing
Screenshots
Changelog
Nothing to add.