[Identity] preserve states when activity is destroyed #5252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccen-stripe
force-pushed
the
ccen/recoverWhenDestroyed2
branch
from
c358d3e
to
255b203
Compare
michelleb-stripe
previously approved these changes
Jul 6, 2022
ccen-stripe
force-pushed
the
ccen/recoverWhenDestroyed2
branch
from
255b203
to
9f241fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes makes sure the SDK works correctly when "don't keep activities" is turned on in developer settings.
PhotoTakerandImageChooserwas refactored to ensure the photo taken/image chosen would be correctly pass back to its calling activity once it's restoredConsentFragmentno longer automatically advances toDocSelectionFragmentwhen consent is granted, this makes sure when activity is restored and the consent boolean is true because a new network request is made, the user can go still back to theConsentFragmentIdentityViewModelandIdentityUploadViewModel's Factory extendingAbstractSavedStateViewModelFactory, so that the upload state could be preserved upon process killDocumentUploadState,SelfieUploadState,AnalyticsState,Resourceare annotated with@Parcelize` in order to be saved.Motivation
Support process kill for Identity SDK
Testing
Screenshots
Changelog