[Identity] Dagger - Move injection to IdentityActivity #5249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move the injection from
IdentityViewModel
toIdentityActivity
to preserve state inIdentityViewModel
This is a change required to make
IdentityViewModelFactory
preserving state after process kill by implementingAbstractSavedStateViewModelFactory
, the reason is as follows:IdentityActivity needs to set a
IdentityFragmentFactory
in order to create different Fragments. This factory is created by dagger graph, and needs to be set in IdentityActivity beforesuper.onCreate()
However in order to make the IdentityViewModel to preserve state with AbstractSavedStateViewModelFactory, it could only be initialized after
super.onCreate()
- note this is not a requirement if it's just a regular ViewModelFactoryBefore the change, the
IdentityViewModel
(andIdentityFragmentFactory
) are all created beforesuper.onCreate()
callAfter the change,
IdentityFragmentFactory
is created before theonCreate()
call, the dependencies requiredIdentityViewModel
is also created before theonCreate()
call, they are all passed to the Factory. The actual creation of IdentityViewModel will beafter
onCreate() call.Motivation
Preserve IdentityViewModelState
Testing
Screenshots
Changelog