New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Autocomplete address screen #5248
Merged
jameswoo-stripe
merged 2 commits into
master
from
jameswoo/shipping-address-element-autocomplete-view
Jul 6, 2022
Merged
Add Autocomplete address screen #5248
jameswoo-stripe
merged 2 commits into
master
from
jameswoo/shipping-address-element-autocomplete-view
Jul 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswoo-stripe
requested review from
brnunes-stripe,
michelleb-stripe and
skyler-stripe
as code owners
July 5, 2022 17:31
jameswoo-stripe
force-pushed
the
jameswoo/shipping-address-element-autocomplete-view
branch
from
July 5, 2022 17:36
ef6e674
to
76d2f6b
Compare
Diffuse output:
APK
MANIFEST
DEX
ARSC
|
jameswoo-stripe
force-pushed
the
jameswoo/shipping-address-element-autocomplete-view
branch
2 times, most recently
from
July 5, 2022 18:00
ef1cf17
to
d9cc3b5
Compare
jameswoo-stripe
commented
Jul 5, 2022
...sheet/src/main/java/com/stripe/android/paymentsheet/addresselement/AddressElementActivity.kt
Outdated
Show resolved
Hide resolved
jameswoo-stripe
force-pushed
the
jameswoo/shipping-address-element-autocomplete-view
branch
2 times, most recently
from
July 6, 2022 06:03
10e9002
to
2414bdb
Compare
jameswoo-stripe
force-pushed
the
jameswoo/shipping-address-element-autocomplete-view
branch
from
July 6, 2022 06:13
2414bdb
to
616f488
Compare
jameswoo-stripe
commented
Jul 6, 2022
@@ -49,4 +49,6 @@ | |||
|
|||
<!-- CardFormView --> | |||
|
|||
<color name="stripe_paymentsheet_shipping_address_background">#1A1A1A0D</color> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talking to Clarissa about this color
// args.config?.googlePlacesApiKey?.let { | ||
// PlacesClientProxy.create(getApplication(), it) | ||
// } | ||
PlacesClientProxy.create(getApplication(), "AIzaSyBajorPDiua9tcfEqa1HXFl74b-a6bWnXM") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
jameswoo-stripe
force-pushed
the
jameswoo/shipping-address-element-autocomplete-view
branch
from
July 6, 2022 18:44
9509ff4
to
e6c211a
Compare
skyler-stripe
approved these changes
Jul 6, 2022
jameswoo-stripe
deleted the
jameswoo/shipping-address-element-autocomplete-view
branch
July 6, 2022 18:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Shipping Address Element
Testing
Screenshots
autocomplete1.mov