From bb93b61b0e1af3deff0841b015026c24e07e4988 Mon Sep 17 00:00:00 2001
From: jameswoo-stripe <99316447+jameswoo-stripe@users.noreply.github.com>
Date: Sat, 25 Jun 2022 10:27:34 -0700
Subject: [PATCH] Fix tests

---
 .../ui/core/forms/resources/LpmRepository.kt  | 10 +++----
 .../core/forms/resources/LpmRepositoryTest.kt | 30 +++++++++++--------
 2 files changed, 21 insertions(+), 19 deletions(-)

diff --git a/payments-ui-core/src/main/java/com/stripe/android/ui/core/forms/resources/LpmRepository.kt b/payments-ui-core/src/main/java/com/stripe/android/ui/core/forms/resources/LpmRepository.kt
index 7f803601163..7dcb486c403 100644
--- a/payments-ui-core/src/main/java/com/stripe/android/ui/core/forms/resources/LpmRepository.kt
+++ b/payments-ui-core/src/main/java/com/stripe/android/ui/core/forms/resources/LpmRepository.kt
@@ -44,7 +44,9 @@ import javax.inject.Singleton
 @Singleton
 @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
 class LpmRepository @Inject constructor(
-    resources: Resources?
+    resources: Resources?,
+    private val isFinancialConnectionsAvailable: IsFinancialConnectionsAvailable =
+        DefaultIsFinancialConnectionsAvailable()
 ) {
     private val lpmSerializer: LpmSerializer = LpmSerializer()
 
@@ -63,11 +65,7 @@ class LpmRepository @Inject constructor(
     }
 
     @VisibleForTesting
-    fun initialize(
-        inputStream: InputStream?,
-        isFinancialConnectionsAvailable: IsFinancialConnectionsAvailable =
-            DefaultIsFinancialConnectionsAvailable()
-    ) {
+    fun initialize(inputStream: InputStream?) {
         val parsedSupportedPaymentMethod = parseLpms(inputStream)
             ?.filter { exposedPaymentMethods.contains(it.type) }
             ?.mapNotNull { convertToSupportedPaymentMethod(it) }
diff --git a/payments-ui-core/src/test/java/com/stripe/android/ui/core/forms/resources/LpmRepositoryTest.kt b/payments-ui-core/src/test/java/com/stripe/android/ui/core/forms/resources/LpmRepositoryTest.kt
index 2662f893d83..8367953bb20 100644
--- a/payments-ui-core/src/test/java/com/stripe/android/ui/core/forms/resources/LpmRepositoryTest.kt
+++ b/payments-ui-core/src/test/java/com/stripe/android/ui/core/forms/resources/LpmRepositoryTest.kt
@@ -13,7 +13,12 @@ import org.robolectric.RobolectricTestRunner
 @RunWith(RobolectricTestRunner::class)
 class LpmRepositoryTest {
     private val lpmRepository = LpmRepository(
-        ApplicationProvider.getApplicationContext<Application>().resources
+        ApplicationProvider.getApplicationContext<Application>().resources,
+        object : IsFinancialConnectionsAvailable {
+            override fun invoke(): Boolean {
+                return true
+            }
+        }
     )
 
     @Test
@@ -121,12 +126,7 @@ class LpmRepositoryTest {
                   "type": "us_bank_account"
                 }
               ]
-            """.trimIndent().byteInputStream(),
-            isFinancialConnectionsAvailable = object : IsFinancialConnectionsAvailable {
-                override fun invoke(): Boolean {
-                    return true
-                }
-            }
+            """.trimIndent().byteInputStream()
         )
 
         assertThat(lpmRepository.fromCode("us_bank_account")).isNotNull()
@@ -134,6 +134,15 @@ class LpmRepositoryTest {
 
     @Test
     fun `Verify that us_bank_account not supported when financial connections sdk not available`() {
+        val lpmRepository = LpmRepository(
+            ApplicationProvider.getApplicationContext<Application>().resources,
+            object : IsFinancialConnectionsAvailable {
+                override fun invoke(): Boolean {
+                    return false
+                }
+            }
+        )
+
         lpmRepository.initialize(
             """
               [
@@ -141,12 +150,7 @@ class LpmRepositoryTest {
                   "type": "us_bank_account"
                 }
               ]
-            """.trimIndent().byteInputStream(),
-            isFinancialConnectionsAvailable = object : IsFinancialConnectionsAvailable {
-                override fun invoke(): Boolean {
-                    return false
-                }
-            }
+            """.trimIndent().byteInputStream()
         )
 
         assertThat(lpmRepository.fromCode("us_bank_account")).isNull()