Preserve stack frame for mock parent method call #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go tip contains following commmit, that inlines function with single call bodies. golang/go@13baf4b `(*Call).On()` is the exact target for the improvement in Go repo. Due to the inlining, assert.CallerInfo() can't not detect the file and line number of the call to `(*Mock).On()` from `(*Call).On()`. Thus, the test fails. Adding the compiler directive `go:noinline` prevent this effect and make mock package works with go tip as before.
|
This would fix #705 |
johnlockwood-wf
approved these changes
Jan 3, 2019
georgelesica-wf
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #705
Go tip contains following commmit, that inlines function with single
call bodies.
golang/go@13baf4b
(*Call).On()is the exact target for the improvement in Go repo. Due tothe inlining, assert.CallerInfo() can't not detect the file and line
number of the call to
(*Mock).On()from(*Call).On(). Thus, the testfails.
Adding the compiler directive
go:noinlineprevent this effect and makemock package works with go tip as before.