Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover panic in suite #696

Merged
merged 1 commit into from Dec 24, 2018

Conversation

YaroslavDev
Copy link

Synopsis

PR implements feature suggested in #695 (don't panic in tests, but gracefully recover, mark test as failed and run other tests)

@YaroslavDev YaroslavDev closed this Dec 4, 2018
@YaroslavDev YaroslavDev reopened this Dec 4, 2018
@YaroslavDev YaroslavDev mentioned this pull request Dec 4, 2018
@iaroslav-ciupin
Copy link

@ernesto-jimenez @matryer can you please take a look ?

@iaroslav-ciupin
Copy link

@georgelesica-wf , can you please take a look ?

@georgelesica-wf
Copy link

Since this is a pretty significant change I'm going to get a few people to look at it and discuss, but I'll keep you posted.

@georgelesica-wf georgelesica-wf added this to the 2.0.0 milestone Dec 15, 2018
@benechols-wf
Copy link

benechols-wf commented Dec 15, 2018

+1 To the general plan. This is roughly the behavior of go tests already (panics are caught by the test framework and reported as a failure) so i think it makes sense for a custom test sit suite to provide the same feature. Also, being able to execute cleanup steps even if there isa panic makes sense.

However it appears there is CI failures so let's get those cleaned up before final approval :)

@iaroslav-ciupin
Copy link

@benechols-wf CI fails only on "Go tip" which is not related to my changes. As you can see, all pull requests(even only with docs 😄 ) are failing on "Go tip".

@georgelesica-wf
Copy link

I created an issue to resolve the CI failures: #705

We'll need to do that before the next release, but I'm fine merging PRs that don't break on released Go versions for now.

@YaroslavDev
Copy link
Author

@georgelesica-wf any ideas when this can be merged?

@georgelesica-wf
Copy link

Sorry, I've been pretty busy. I'll merge it now, thank you for your patience! Sorry it took awhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants