Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo ("PASS" -> "FAIL") #670

Merged
merged 1 commit into from Jan 3, 2019
Merged

Conversation

xtonyjiang
Copy link
Contributor

Fixes #669

@devdinu
Copy link
Contributor

devdinu commented Sep 18, 2018

func Test_Arguments_Diff_WithArgMatcher(t *testing.T) have the case to check assert with argumentMatcher and Diff is called for Assert, so when it's mismatched, output should've FAIL.

@bodnarbm
Copy link

@devdinu, I believe the test cited (Test_Arguments_Diff_WithArgMatcher) only asserts the portion of the message after the PASS or FAIL statements. Thus, it was not caught here where the message had the proper "not matched by" output, but had the erroneous "PASS".

Copy link

@bodnarbm bodnarbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We may wish to consider if "PASS" and "FAIL" should be included in the expected strings in Test_Arguments_Diff_WithArgMatcher

@georgelesica-wf georgelesica-wf added this to the Next Release milestone Jan 3, 2019
@georgelesica-wf
Copy link

Re-running CI, I'll merge once it finishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants