Allow assert.Equal on string type alias without panicking on failure #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaraldNordgren
commented
Sep 11, 2018
| if !Equal(mockT, &struct{}{}, &struct{}{}) { | ||
| t.Error("Equal should return true (pointer equality is based on equality of underlying value)") | ||
| } | ||
| var m map[string]interface{} | ||
| if Equal(mockT, m["bar"], "something") { | ||
| t.Error("Equal should return false") | ||
| } | ||
| if Equal(mockT, myType("1"), myType("2")) { | ||
| t.Error("Equal should return false") | ||
| } |
There was a problem hiding this comment.
This test will panic if the fix in assert/assertions.go is reverted.
This was referenced Sep 11, 2018
georgelesica-wf
added
bug
rejected/duplicate
input needed
and removed
rejected/duplicate
input needed
labels
georgelesica-wf
approved these changes
Sep 18, 2018
|
@ernesto-jimenez @georgelesica-wf Merge this? 😊 |
|
@HaraldNordgren I'm waiting on merge permissions from @matryer - hang tight, sorry! |
autarch
added a commit
to autarch/intro-to-go-class-exercises
that referenced
this pull request
Jan 4, 2019
The last tagged version of testify, 1.2.2, has a bug that causes a lot of issues for the class, fixed with stretchr/testify#661
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Apr 3, 2019
Keep running into [googleforgames#661](stretchr/testify#661) - Allow assert.Equal on string type alias without panicking on failure So upgrading Testify to solve this.
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Apr 3, 2019
Keep running into [googleforgames#661](stretchr/testify#661) - Allow assert.Equal on string type alias without panicking on failure So upgrading Testify to solve this.
markmandel
added a commit
to googleforgames/agones
that referenced
this pull request
Apr 4, 2019
Keep running into [#661](stretchr/testify#661) - Allow assert.Equal on string type alias without panicking on failure So upgrading Testify to solve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ernesto-jimenez The old comparison against
reflect.Stringis true for type aliases of string, but the type coercion panics. So let's compare the type instead of the kind, to avoid the panics.Fixes #644
Fixes #646