New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the LICENSE to match the 'standard' MIT license file #648
Conversation
It looks to me like this should be fine, but I think we should review it carefully nonetheless. Assuming there are no problems here, I think it's a good idea to make the license more obvious. |
If the license is altered to conform with the standard MIT license, I do not believe the copyright year should be altered to state only the current year. I believe the standard is to use the year of first publication of the work (which should be 2012). Alternatively the year range could be maintained and updated to |
@omarkohl do you mind addressing the comment about the copyright year? |
OK, I'll update it |
The reason is that since the name of the license is not stated explicitly and the license text differed very slightly I had to perform a diff to ensure it actually is MIT licensed. Also GitHub does not detect the license for this project currently (probably for the same reason). Changes: * Remove the line 'Please consider promoting this project...' that is not part of the MIT license * Use the same formatting as choosealicense.com * Explicitly state 'MIT License' * Update the copyright year
Friendly ping... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for making those updates. Very sorry this took so long, working on getting better at responding!
Pulling in stretchr/testify@199de5f3a4 (Update the LICENSE to match the 'standard' MIT license file, 2018-08-16, stretchr/testify#648) to drop the "Please consider promoting this project..." deviation from the stock MIT license. Generated with: $ dep ensure -update github.com/stretchr/testify using: $ dep version dep: version : v0.5.1 build date : 2019-03-20 git hash : faa61893 go version : go1.10.3 go compiler : gc platform : linux/amd64 features : ImportDuringSolve=false
The reason is that since the name of the license is not stated
explicitly and the license text differed very slightly I had to perform
a diff to ensure it actually is MIT licensed. Also GitHub does not
detect the license for this project currently (probably for the same
reason).
Changes:
not part of the MIT license