Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suite.TestingT incompatible with gomock.TestReporter #878

Closed
shousper opened this issue Jan 29, 2020 · 2 comments · Fixed by #885
Closed

suite.TestingT incompatible with gomock.TestReporter #878

shousper opened this issue Jan 29, 2020 · 2 comments · Fixed by #885

Comments

@shousper
Copy link
Contributor

A recent change has broken compatibility with gomock when using suites.

The gomock.TestReporter interface requires the Fatalf method which is missing from suite.TestingT. This has only become a problem now that the Suite.T() method returns this interface instead of *testing.T. I believe this was the breaking change: #867

If the extra method could be added to the interface, that'd be great. I'm honestly not sure otherwise what a good solution would be to avoid breaking compatibility with other libraries. Perhaps just ensuring that the entire public interface of testing.T is represented in the return type of Suite.T()?

@phlogistonjohn
Copy link

One might also argue that changing the return type this way is an API breaking change and would call for a 2.x version number according to the go module rules.

@glesica
Copy link
Collaborator

glesica commented Feb 7, 2020

I'd like to get this into the next release, which is almost certainly going to be 2.0.0. If someone wants to take it on, that'd be great. If not, I'll try to get to it before we cut the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants