You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A recent change has broken compatibility with gomock when using suites.
The gomock.TestReporter interface requires the Fatalf method which is missing from suite.TestingT. This has only become a problem now that the Suite.T() method returns this interface instead of *testing.T. I believe this was the breaking change: #867
If the extra method could be added to the interface, that'd be great. I'm honestly not sure otherwise what a good solution would be to avoid breaking compatibility with other libraries. Perhaps just ensuring that the entire public interface of testing.T is represented in the return type of Suite.T()?
The text was updated successfully, but these errors were encountered:
One might also argue that changing the return type this way is an API breaking change and would call for a 2.x version number according to the go module rules.
I'd like to get this into the next release, which is almost certainly going to be 2.0.0. If someone wants to take it on, that'd be great. If not, I'll try to get to it before we cut the release.
A recent change has broken compatibility with
gomock
when using suites.The
gomock.TestReporter
interface requires theFatalf
method which is missing fromsuite.TestingT
. This has only become a problem now that theSuite.T()
method returns this interface instead of*testing.T
. I believe this was the breaking change: #867If the extra method could be added to the interface, that'd be great. I'm honestly not sure otherwise what a good solution would be to avoid breaking compatibility with other libraries. Perhaps just ensuring that the entire public interface of
testing.T
is represented in the return type ofSuite.T()
?The text was updated successfully, but these errors were encountered: