Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for subtests #693

Closed
itzamna314 opened this issue Nov 28, 2018 · 1 comment
Closed

Add support for subtests #693

itzamna314 opened this issue Nov 28, 2018 · 1 comment

Comments

@itzamna314
Copy link
Contributor

When using table-driven tests with suite, it is useful to use sub-tests to break up the go test output by table case. However, suite doesn't provide any way to get the correct testing.T instance into its built-in assertions.

I've already put together a PR to add this functionality, so I'm just creating the issue for visibility. Please let me know if there's anything else needed to get the PR merged, or if there are any objections to this feature.
@georgelesica-wf
Copy link

PR merged. Closing. #655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itzamna314 @georgelesica-wf