Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vgo vendor fail #615

Closed
mwf opened this issue Jun 13, 2018 · 3 comments
Closed

vgo vendor fail #615

mwf opened this issue Jun 13, 2018 · 3 comments

Comments

@mwf
Copy link

mwf commented Jun 13, 2018

Hi guys!

FYI I found an issue regarding vgo usage along with go-spew and testify - golang/go#25871

Any project using testify can't be vendored with vgo vendor command.

Could you please subscribe to it?
Maybe it's worth taking part in the discussion in case of any concerns from Go team.

Many thanks :)
@ernesto-jimenez
Copy link
Member

Hi @mwf,

That right now depends on some vgo fixes or us making some breaking changes. See #607

@mwf
Copy link
Author

mwf commented Jun 14, 2018

Actually it doesn't depend on you, it's just a bug in vgo and they're going to fix it.

@mwf
Copy link
Author

mwf commented Jun 15, 2018

vgo is fixed, closing the issue

@mwf mwf closed this as completed Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ernesto-jimenez @mwf