Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: new assertionInEpsilonMapValues #1497

Open
Antonboom opened this issue Oct 29, 2023 · 3 comments · May be fixed by #1500
Open

proposal: new assertionInEpsilonMapValues #1497

Antonboom opened this issue Oct 29, 2023 · 3 comments · May be fixed by #1500
Labels
assert.InEpsilon About assert.InEpsilon and family enhancement pkg-assert Change related to package testify/assert

Comments

@Antonboom
Copy link

Hi!

To be consistent with InDeltaMapValues package could provide InEpsilonMapValues.

Like InDeltaSlice and InEpsilonSlice.

Thanks.
@Antonboom Antonboom changed the title proposal: InEpsilonMapValues proposal: new assertionInEpsilonMapValues Oct 29, 2023
@dolmen dolmen added enhancement pkg-assert Change related to package testify/assert assert.InEpsilon About assert.InEpsilon and family labels Oct 31, 2023
@hendrywiranto
Copy link
Contributor

Hi @Antonboom , is this an issue that you want to work on yourself or anyone can take it if they wanted to?
if it's free to take I'm willing to work on this... thanks :)

@Antonboom
Copy link
Author

@hendrywiranto hi!
Feel free to contribute 👌

@hendrywiranto hendrywiranto linked a pull request Nov 1, 2023 that will close this issue
Open
@hendrywiranto
Copy link
Contributor

I opened a PR for this, can you please take a look? thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assert.InEpsilon About assert.InEpsilon and family enhancement pkg-assert Change related to package testify/assert
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

assert: Add new assertion InEpsilonMapValues hendrywiranto/testify
3 participants
@dolmen @Antonboom @hendrywiranto