Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assert.MapSubset (or just support maps in assert.Subset) #1178

Merged
merged 2 commits into from Jun 28, 2022
Merged

fix: assert.MapSubset (or just support maps in assert.Subset) #1178

merged 2 commits into from Jun 28, 2022

Conversation

OladapoAjala
Copy link
Contributor

Summary

Extended Subset & NotSubset to handle maps

Changes

Added some logic to check if each subsets key-value pair are present in the list.

Motivation

To handle maps in Subset & NotSubset

Related issues

#1173

@OladapoAjala OladapoAjala changed the title WIP: added map key value check in subset fix: assert.MapSubset (or just support maps in assert.Subset) #1173 Apr 20, 2022
@OladapoAjala OladapoAjala changed the title fix: assert.MapSubset (or just support maps in assert.Subset) #1173 fix: assert.MapSubset (or just support maps in assert.Subset) Apr 20, 2022
Copy link
Collaborator

@boyan-soubachov boyan-soubachov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants