New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: assert.MapSubset (or just support maps in assert.Subset) #1173
Comments
Enhancing Subset would definitely be better IMO. One question, should this assert true? a := map[string]string{
"one": "foo",
"two": "bar",
}
b := map[string]string{
"one": "baz",
}
assert.Subset(t, a, b) Does it test that the key and value are in the superset, or does it follow two value dereference ( |
it should test both the key and the value. |
@brackendawson What is the process to having this proposal accepted? If accepted @SleepyBrett can I work on it? |
That would be open a pull request and then hope a maintainer returns. |
@brackendawson sure thanks, would create a PR. |
Hello @brackendawson @SleepyBrett I created a PR for this issue here: #1178 |
FYI testify |
While looking for this exact functionality I came across this ticket and #704 which looks like a duplicate. |
or perhaps expand subset so it can also handle maps.
given
The text was updated successfully, but these errors were encountered: