Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag v0.1 as v0.1.0 #80

Closed
leighmcculloch opened this issue Jun 10, 2018 · 8 comments
Closed

Tag v0.1 as v0.1.0 #80

leighmcculloch opened this issue Jun 10, 2018 · 8 comments
Milestone

Comments

@leighmcculloch
Copy link

vgo requires that versions have three parts, like v0.1.0, but the only version tagged for objx is v0.1, and so vgo is unable to use that version. Could you please add a tag at the same commit as v0.1, and name it v0.1.0?

You can do this by:

git tag -a v0.1.0 v0.1
git push origin v0.1.0

This is required to close stretchr/testify#607.

@hanzei
Copy link
Collaborator

hanzei commented Jun 10, 2018

V0.1.1 just got released https://github.com/stretchr/objx/releases/tag/v0.1.1

@hanzei hanzei closed this as completed Jun 10, 2018
@leighmcculloch
Copy link
Author

Thanks @hanzei !

@leighmcculloch
Copy link
Author

@hanzei I see you created the new tag, but it's not at the same sha. The version needs tagging at the same sha, not a new sha. Otherwise vgo won't be able to pull in version v0.1.0.

@hanzei
Copy link
Collaborator

hanzei commented Jun 24, 2018

I just taged a new version. can't you use v0.1.1?

@leighmcculloch
Copy link
Author

The new version is a different sha. Can you add a tag for the existing sha that v0.1 points to? Then testify can update it's dependency reference without changing which sha it references.

@leighmcculloch
Copy link
Author

If you're up for doing this but not sure how I can help.

@hanzei
Copy link
Collaborator

hanzei commented Jun 26, 2018

It should be fixed now

@leighmcculloch
Copy link
Author

Thanks!

@hanzei hanzei added this to the v0.1 milestone Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants