Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropbox support no longer available? #36

Open
jamiefoster opened this issue Aug 9, 2015 · 2 comments
Open

Dropbox support no longer available? #36

jamiefoster opened this issue Aug 9, 2015 · 2 comments

Comments

@jamiefoster
Copy link

I see that Dropbox support was added a while back but it seems gone now.

Was it removed?

Thanks,
Jamie

@matryer
Copy link
Member

matryer commented Aug 9, 2015

It's here - maggit@ad5f3a9

Trying to get a PR.

@maggit
Copy link
Contributor

maggit commented Aug 28, 2015

Hey @matryer sorry I took so long to respond, had a lot on my plate lately. I worked on the dropbox support but I ran into an issue, maybe together we can figure it out the best way to solve it. Basically access_type, and approval_prompt are "unknown" parameters for dropbox, you can check the documentation https://www.dropbox.com/developers/core/docs#oa2-authorize

screen shot 2015-08-28 at 4 09 31 pm
screen shot 2015-08-28 at 4 09 21 pm

I was thinking on removing the extra parameters on GetBeginAuthURL perhaps using regular expressions or if you have any other suggestion, please let me know.

oauth2.GetBeginAuthURLWithBase(provider.config.Get(oauth2.OAuth2KeyAuthURL).Str(), state, provider.config)

we need to remove: access_type=&approval_prompt=&

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants