Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet: Wrong target path 'js' #29

Open
bitflower opened this issue Nov 27, 2015 · 4 comments
Open

NuGet: Wrong target path 'js' #29

bitflower opened this issue Nov 27, 2015 · 4 comments
Assignees
Milestone

Comments

@bitflower
Copy link

After installing with NuGet the 2 files are placed inside the path 'js'.

It should be "scripts" though.

@MikeMayer MikeMayer added this to the v1.4 milestone Nov 27, 2015
@MikeMayer MikeMayer self-assigned this Nov 27, 2015
@MikeMayer
Copy link
Contributor

I found that the scripts versus js folder was inconsistent across packages on NuGet. Did the community converge on scripts? Can you provide a link on some documentation on a standard for this? I googled around a bit for it and it was still unclear.

I added the nuspec package when I was working for a different employer. I don't use Windows/Visual Studio at all anymore so I'm a bit out of touch. Thanks for this.

I just created a release_1-4 branch that can include this fix if we can make a choice on this one. Thanks.

@bitflower
Copy link
Author

Hey Mike,

Well I have develop VS the last 6 years around half of my time and never has a NuGet Package installed a file into a folder called "js".

It was really like - damn - the package didn't work..

On the other hand no one has critized this. Hm.

@MikeMayer
Copy link
Contributor

Yep. I have about that magnitude of experience with Visual Studio/Microsoft too. I don't feel strongly about this either way. I'll update the nuspec.

You'd like it to be 'Scripts/' right?

@bitflower
Copy link
Author

Exacto! Thanks Mike

MikeMayer added a commit that referenced this issue Nov 28, 2015
Typically NuGet packages copy javascript resources to Scripts/ and this
commit fixes arg.js.nuspec to be more conventional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants