Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue #5286: Add some words that start with "un" to the US dictionary #3129

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

klonos
Copy link

@klonos klonos commented Apr 25, 2024

Fixes streetsidesoftware/cspell#5286

Add/Fix Dictionary

Dictionary: US

Description

CSpell has been nagging about these words found in the Backdrop CMS codebase, but they are not specific to that.

It also adds the word instantiatable, since it is an actual word (see https://en.wiktionary.org/wiki/instantiatable), as well as its uninstantiatable counterpart.

References

backdrop/backdrop-issues#6302

Checklist

  • By submitting this pull-request, you agree to follow our Code of Conduct
  • Verify that the title starts with the correct prefix:
    • fix: - for minor changes like adding words or fixing spelling issues.
    • feat: - for a significant change like adding a whole new set of words to a dictionary.
    • feat!: - for breaking changes, like file format or licensing changes.
    • chore: - for changes that do not impact the content of dictionaries.

Fixes streetsidesoftware/cspell#5286

CSpell has been nagging about these words found in the Backdrop CMS codebase.
@Jason3S
Copy link
Collaborator

Jason3S commented Apr 25, 2024

@klonos,

Thank you for taking a look at this.

Some of the terms are more programming related than part of general English.

For example, what does unescapes mean when it is not in a programming context?

The other drawback to adding them to the US English dictionary is that they are only available to those who use en-US and not en-GB.

If a term is primarily used when writing code, please add it to dictionaries/software-terms/src/software-terms.txt.

If you feel it is a universal term (all flavors of English), then consider adding it to dictionaries/en_shared/src/shared-additional-words.txt

@Jason3S
Copy link
Collaborator

Jason3S commented May 6, 2024

@klonos,

Will you be able to adjust the PR as suggested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants