Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable incremental typescript builds #1671

Merged
merged 1 commit into from Sep 11, 2021

Conversation

mad-gooze
Copy link
Contributor

@mad-gooze mad-gooze commented Sep 10, 2021

TypeScript support incremental build mode which caches build results in filesystem (see here)

Enabling this speeds up npm run build more than 2x on my machine.

@Jason3S
Copy link
Collaborator

Jason3S commented Sep 11, 2021

Excellent! Thank you.

@Jason3S Jason3S merged commit 3a884db into streetsidesoftware:main Sep 11, 2021
Jason3S added a commit that referenced this pull request Sep 12, 2021
@Jason3S
Copy link
Collaborator

Jason3S commented Sep 12, 2021

I had to revert this pull request because it was breaking deployment.

Once I clean up the deploy steps, I'll add it back.

The deploy steps are a bit overly complicated to prevent deploying broken packages. The risk of deploying a broken package was considered higher than the cost of running multiple build / test passes during the deployment. The incremental build setting breaks multiple build passes because the package.json files change between passes (this is due to how Lerna publishes a package).

In any case, thank you for trying to speed up development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants