Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"copywright" is not marked as misspelled in some files #1037

Closed
itsmaxymoo opened this issue Apr 22, 2022 · 6 comments
Closed

"copywright" is not marked as misspelled in some files #1037

itsmaxymoo opened this issue Apr 22, 2022 · 6 comments

Comments

@itsmaxymoo
Copy link

This is the file in question, Line 27

It appears "copywright" is not marked as misspelled in one source code file. It is normally marked as incorrect, but not in this particular file. A quick grep through this repository shows "copywright" doesn't exist anywhere, so I'm unsure if this is the correct repo for this issue.

This is occurring using the Visual Studio Code "Code Spell Checker" extension on Linux, with the following other extensions installed:

ms-python.python
ms-python.vscode-pylance
ms-toolsai.jupyter
ms-toolsai.jupyter-keymap
ms-toolsai.jupyter-renderers
ms-vscode.cpptools
njpwerner.autodocstring
streetsidesoftware.code-spell-checker
syler.sass-indented
twxs.cmake

In the file, cSpell lists the following dictionaries as active:

backwards-compatibility
aws
companies
cpp
cryptocurrencies
en_us
filetypes
fullstack
public-licenses
softwareTerms
@nschonni
Copy link
Collaborator

Do you have allowCompoundWords set to true https://github.com/streetsidesoftware/cspell/tree/main/packages/cspell#cspelljson-sections? And does it get flagged if your run from the CLI instead of https://github.com/streetsidesoftware/vscode-spell-checker

@itsmaxymoo
Copy link
Author

  1. allowCompoundWords is false
  2. It does not get flagged from the CLI. May this be a vscode specific issue?
  3. I can confirm this issue persists across two devices now.

@Jason3S
Copy link
Collaborator

Jason3S commented Apr 23, 2022

@itsmaxymoo,

If it happens in one type of file and not in others, then it is most likely an issue with allowCompoundWords. I'm guessing it is a Python file that has the issue.

Please try adding the following to your configuration

cspell.json

{
    "languageSettings": [
        {
            "languageId": "*",
            "allowCompoundWords": false
        }
    ]
}

"languageId": "*" will match all file types. To match only Python files, use "languageId": "python"

@itsmaxymoo
Copy link
Author

That appeared to fix it... This was a C file. It may be advantageous to blacklist "copywright"...

@Kurt-von-Laven
Copy link
Collaborator

Attempting to blacklist compound words seems Sisyphean to me. It sounds like a very high ratio of maintainer effort to value added, particularly given that compound words can be banned by a setting.

Jason3S added a commit to streetsidesoftware/cspell that referenced this issue May 2, 2022
**Semi-Breaking change**

The updated python dictionary no longer sets `allowCompoundWords` to `true`. If you want the old behavior, add the following to your `cspell.json` file:

**`cspell.json`**
```json
{
    "languageSettings": [
        {
            "languageId": "python",
            "allowCompoundWords": true
        }
    ]
}
```

Note: setting `allowCompoundWords` to `true` hides many misspellings.

See: 
- streetsidesoftware/cspell-dicts#1037
- #1937
- #1626
- #1154
- #999
- #317
@Jason3S
Copy link
Collaborator

Jason3S commented May 18, 2022

Fixed in new release.

@Jason3S Jason3S closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants