Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include problem matcher so issues are highlighted in PRs #9

Open
nschonni opened this issue Aug 10, 2020 · 4 comments
Open

Include problem matcher so issues are highlighted in PRs #9

nschonni opened this issue Aug 10, 2020 · 4 comments

Comments

@nschonni
Copy link

nschonni commented Aug 10, 2020

EX: https://github.com/xt0rted/markdownlint-problem-matcher/blob/master/.github/problem-matcher.json
The matcher needs to be registered as part of the action rather than manually added to repos registered like https://github.com/dotnet/docs/blob/c3a769228cb87c7394a5baaffc7a28f6d1fc24bd/.github/workflows/markdownlint.yml#L30

Here are the registration lines from that repo from the API instead of the commandline https://github.com/xt0rted/markdownlint-problem-matcher/blob/31939ffafb5b423ffafae13bd3aad77d36481133/src/main.ts#L19-L25

@nschonni nschonni changed the title Include problem matcher issues are highlighted in PRs Include problem matcher so issues are highlighted in PRs Aug 10, 2020
@Jason3S
Copy link
Contributor

Jason3S commented Dec 17, 2020

@nschonni this action will annotate the pull-request.

@nschonni
Copy link
Author

Sorry, are you saying it should be doing this now, or will in the future?

@Jason3S
Copy link
Contributor

Jason3S commented Dec 17, 2020

This github action (cspell-action) now works. It will report errors in pull-requests and mark the files with warnings.

There are some more options that need to be implimented:

  1. specify the path to the config file
  2. specify a list files
  3. option to fail the build if spelling errors are found
  4. output a summary of the results.

@jankatins
Copy link

jankatins commented Aug 22, 2022

I tried this action and there are not review comments for problematic lines :-( Was that supposed to work already or is that not yet implemented (can't quite get it from the last comment: what does "report errors in pull-requests" mean)?

Now the review comments showed up -> PR comments for typos work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants