Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading cspell.json from a URL #869

Open
Nightblade opened this issue Aug 3, 2022 · 2 comments
Open

Support reading cspell.json from a URL #869

Nightblade opened this issue Aug 3, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@Nightblade
Copy link

Nightblade commented Aug 3, 2022

Description

Can't use cspell.json from a URL.

To Reproduce

  1. Create a minimal cspell-action.yml in a repo (note the config: param) :
name: 'cspell-action-test'

on:
  pull_request:
  push:
  workflow_dispatch:

jobs:
  spellcheck:
    runs-on: ubuntu-latest
    steps:
      - name: Check out repo
        uses: actions/checkout@v3

      - name: Run cspell-action
        uses: streetsidesoftware/cspell-action@v2.4.0
        with:
          config: 'https://raw.githubusercontent.com/Nightblade/pob-dict/main/cspell.json'
  1. Run the action.
  2. Check the action's log.
  3. See error: Error: Configuration file "https://raw.githubusercontent.com/Nightblade/pob-dict/main/cspell.json" not found.
  4. Details: https://github.com/Nightblade/PathOfBuilding/runs/7643610725?check_suite_focus=true

Expected behavior

Allow using cspell.json (and dictionaries) from a URL.

@Nightblade
Copy link
Author

Sorry, I just realised I probably should've put this in https://github.com/streetsidesoftware/cspell-action
Happy to re-create it there if you prefer.

On reflection, this is probably a feature request as well... I'm winning today already!

@Jason3S Jason3S transferred this issue from streetsidesoftware/cspell Aug 6, 2022
@Jason3S Jason3S added enhancement New feature or request and removed bug Something isn't working Needs Investigating new issue labels Aug 6, 2022
@Jason3S Jason3S changed the title Can't use cspell.json from a URL? Support reading cspell.json from a URL Aug 6, 2022
@nicorikken
Copy link

This would be great. I'm now looking to deploy a default cspell action in my organization. Now I'd have to wrap the cspell-action in a action that takes care of writing/copying the organization-default cspell.json and installing dictionaries. Having that be part of cspell or cspell-action would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants