Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate cspell.json #182

Open
Kurt-von-Laven opened this issue May 29, 2021 · 4 comments
Open

Validate cspell.json #182

Kurt-von-Laven opened this issue May 29, 2021 · 4 comments

Comments

@Kurt-von-Laven
Copy link

Kurt-von-Laven commented May 29, 2021

If one were to say... misspell the name of a dictionary... there would presently be no immediate indication they had done so (other than the universe itself abruptly imploding from the sheer irony of it all, of course).

@Jason3S
Copy link
Contributor

Jason3S commented Jun 2, 2021

A workaround is to run npx cspell "*". It will report on any issues.

@Kurt-von-Laven
Copy link
Author

That is helpful to know. I'm not sure whether it's worth the performance hit to us specifically since I can probably usually remember to click through and inspect the action.

@Jason3S
Copy link
Contributor

Jason3S commented Jun 2, 2021

Ahh, now I understand. You want it to report that the cspell.json file is not valid during the ci/cd steps.

I think that might be the same as #187.

@Kurt-von-Laven
Copy link
Author

Sorry for the vague bug reports. I think this may be a separate issue, but I could certainly believe that a single change to the action would address both. Misspelling the name of a dictionary doesn't generate any kind of warning or error even if you click through to view the action output. The other issue (#187) is that even when a warning or error is generated, it doesn't fail the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants