Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support suggestions (--show-suggestions) for words added via flagWords #1455

Open
klonos opened this issue Nov 23, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@klonos
Copy link

klonos commented Nov 23, 2023

Problem summary

Words added via flagWords are detected as "unknown word" and there is no suggestions despite having configured some in the settings file.

Details

As per https://streetsidesoftware.com/vscode-spell-checker/docs/configuration/#cspellflagwords, we have the following configured in the cspell.json GHA configuration file for our project:

  "flagWords": [
    "blacklist: denylist, deny list, deny, block, denied list, blocked list",
    "blacklisted: disallowed, denied, blocked",
    "blacklisting: disallowing, denying, blocking",
    "master: primary, main, active, default, base",
    "slave: secondary, replica, standby, fallback",
    "webmaster: admin, administrator",
    "whitelist: allowlist, allow list, allow, allowed list",
    "whitelisted: allowed",
    "whitelisting: allowing"
  ],

However, this is the output:

As you can see, there are no suggestions, and the words are reported as "unknown" instead of "flagged".

@Jason3S
Copy link
Contributor

Jason3S commented Nov 24, 2023

@klonos,

You bring up a good point. That action reporting hasn't been updated since the suggestion feature was added.

@Jason3S Jason3S added the enhancement New feature or request label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants