Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

PR-20833: [improve][broker] Add bookkeeperDeleted in topic internal stats. #5836

Open
1 of 15 tasks
streamnativebot opened this issue Jul 19, 2023 · 0 comments
Open
1 of 15 tasks

Comments

@streamnativebot
Copy link

url: apache#20833

Motivation

Shows the offload detail of the ledgers whether it is deleted in bookkeeper.

The ./bin/pulsar-admin topics stats-internal command now shows the ledger info of specific topic. If we are using offloader, we can know the offloaded of the ledger but not be able to know whether it is deleted in bookkeeper.

image

Modifications

Add bookkeeperDeleted field in org.apache.pulsar.common.policies.data.ManagedLedgerInternalStats.LedgerInfo.

Fill the bookkeeperDeleted in all places where offloaded be filled.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • org.apache.pulsar.tests.integration.offload.TestBaseOffload#testPublishOffloadAndConsumeDeletionLag

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: dragonls#11

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant