Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disabled to st.select_slider #4314

Merged
merged 1 commit into from Jan 25, 2022

Conversation

mayagbarnes
Copy link
Collaborator

馃摎 Context

Disabled widgets was previously rolled out and a widget was missed - this PR adds the disabled param as a keyword-only arg to st.select_slider.
Note: select_slider also uses the Slider proto, so no update to proto file necessary.

  • What kind of change does this PR introduce?

    • Bugfix

馃 Description of Changes

  • Added disabled to st.select_slider

    • This is a visible (user-facing) change

Revised:
Screen Shot 2022-01-24 at 1 04 47 PM

馃И Testing Done

  • Screenshots included
  • Added/Updated unit tests
  • Added/Updated e2e tests

馃寪 References

Related PR:


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@mayagbarnes mayagbarnes marked this pull request as ready for review January 24, 2022 21:48
@mayagbarnes mayagbarnes merged commit 8795e0c into streamlit:develop Jan 25, 2022
@mayagbarnes mayagbarnes deleted the fix-select-slider branch January 25, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants