New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react-markdown to version 6 #4221
Upgrade react-markdown to version 6 #4221
Conversation
This resolves some issues with markdown. The upgrades introduced some breaking changes, so the changes have been made
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 馃槃
Admittedly, I still find the updated snapshots for caption-3.snap.png
& caption-3-dark.snap.png
confusing... if I'm understanding, the vertical gap between "This is a caption that contains" and "html" is bc of the <div>
tag... but I would think the intended behavior is for the word "html" to be rendered within the <div>
tag like in the original screenshot.
Yea. The main reason is that When markdown is written in plain text (no header, etc) it's assumed to be in a the word "html" remains in the See the PR preview and you can see when you select the caption test https://share.streamlit.io/streamlit/core-previews/pr-4221 |
Gotcha! And spacing makes more sense now, it isn't coming from a blank |
馃摎 Context
This resolves some issues with markdown. The upgrades introduced
some breaking changes, so the changes have been made. Specifically:
NOTE: Specific upgrade to version 6 over version 7. Version 7 forces us onto ESM. I think it's possible but requires much more refactor.
What kind of change does this PR introduce?
馃И Testing Done
馃寪 References
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.