Replace legacy app URLs in docs with custom subdomains #4959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnOctopus
pushed a commit
that referenced
this pull request
Jul 13, 2022
* Replace legacy app URLs in docs with custom subdomains * Resize height for st.tabs docs app
kmcgrady
added a commit
that referenced
this pull request
Jul 28, 2022
* Up version to 1.11.0 * Replace legacy app URLs in docs with custom subdomains (#4959) * Replace legacy app URLs in docs with custom subdomains * Resize height for st.tabs docs app * Ignore component requests outside of the component root * Up version to 1.11.1 * Fix linting * Revert "Ignore component requests outside of the component root" This reverts commit 80d9979. Co-authored-by: Amanda Walker <amanda@amandawalker.io> Co-authored-by: Snehan Kekre <snehan.minerva@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摎 Context
The custom subdomain feature on Streamlit Cloud will soon be ready for GA. As such, legacy share.streamlit.io URLs of apps embedded in element docstrings should be replaced by their custom subdomain counterparts. These URLs are parsed from docstrings, and the associated apps are iframed/embedded in our docs. Apps with the legacy URLs will no longer work in iframes. We should include this PR in the upcoming release.
What kind of change does this PR introduce?
馃 Description of Changes
Replaces legacy share.streamlit.io URLs in element docstrings with custom subdomains. The mapping between old and new app URLs is found in this Notion table.
Revised:
Current:
馃И Testing Done
馃寪 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.