Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that GitRepo can handle import failures #4942

Merged
merged 1 commit into from Jul 8, 2022

Conversation

vdonato
Copy link
Collaborator

@vdonato vdonato commented Jul 7, 2022

馃摎 Context

We're working toward proper/official support for a conda distribution of Streamlit (there's currently
only a conda-forge release of the library that we don't treat with the same amount of care
as our PyPI distribution). In this release, we only want to include dependencies that exist in the
conda default channel, which will require us to make certain conda-forge-only dependencies optional
or to remove them entirely.

For the gitpython dependency (which is one of these conda-forge-only dependencies), we already
quite conveniently wrote the code using it in such a way that it's resilient to the package not being
installed, but we didn't have a unit test to verify that things work as expected in this case. This PR
simply adds that unit test.

  • What kind of change does this PR introduce?

    • Other, please describe: more tests

馃И Testing Done

  • Added/Updated unit tests

@vdonato vdonato requested a review from a team July 7, 2022 20:11
Copy link
Collaborator

@LukasMasuch LukasMasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

lib/tests/streamlit/git_util_test.py Show resolved Hide resolved
@vdonato vdonato merged commit 03babac into streamlit:develop Jul 8, 2022
@vdonato vdonato deleted the gitpython-test branch July 8, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants