Fix widgets overwrites from short to long-hand props #4935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgrady
reviewed
Jul 7, 2022
| Input: { | ||
| style: { | ||
| padding: ".5rem", | ||
| borderWidth: "1px", |
There was a problem hiding this comment.
Same as the other comment
| }, | ||
| }, | ||
|
|
||
| InputContainer: { | ||
| style: { | ||
| borderWidth: "1px", |
There was a problem hiding this comment.
Yep, I removed that intentionally since it did not seem to actually do anything. Having borderWidth in Root is the only place that has an impact.
kmcgrady
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摎 Context
The PR #4861 applied some changes to border and padding via short-hand properties (
padding,borderWidth) in the baseweb overwrites. Apparently, this leads to weird bugs and warnings:We need to use the long-hand properties instead (
borderLeftWidth,borderRightWidth,borderTopWidth,borderBottomWidth).What kind of change does this PR introduce?
馃 Description of Changes
馃И Testing Done
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.