Add gap param to st.columns #4887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayagbarnes
commented
Jul 1, 2022
| } | ||
|
|
||
| export const StyledColumn = styled.div<StyledColumnProps>( | ||
| ({ weight, theme }) => { | ||
| ({ weight, gap, theme }) => { | ||
| const percentage = weight * 100 |
There was a problem hiding this comment.
Note: both the HorizontalBlock (parent element) and each of the StyledColumns need to be aware of the specified gap
mayagbarnes
commented
Jul 1, 2022
| @@ -30,4 +30,5 @@ export const spacing = { | |||
| xl: "1.25rem", | |||
| twoXL: "1.5rem", | |||
| threeXL: "2rem", | |||
There was a problem hiding this comment.
Wasn't sure if I should add the new rem specification for large gap (4 rem) to the theme's spacing object... Can remove this if its unnecessary.
|
LGTM 馃憤 |
kajarenc
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摎 Context
This PR adds a keyword-only argument gap to
st.columnsto allow users additional layout flexibility.馃 Description of Changes
Add gap as keyword only param to st.columns & validate input one of None, "small", "medium", or "large"
Pass gap to Horizontal & Column messages in Block.proto
Add gap as prop to StyledHorizontalBlock & StyledColumn
Set gap CSS property in StyledHorizontalBlock based on user-specified gap size
Adjust width CSS property in StyledColumn based on user-specified gap size
Revised:
Current:
馃И Testing Done
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.