Rerender Maybe components when they're first disabled #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\streamlit#2395 ended up being caused by this since we don't rerender placeholder components created by `st.empty()` when react props/state change as a performance optimization, but we need to do so when replacing an existing component with an empty one to get rid of what's currently drawn on screen. Closes streamlit#2395
akrolsmir
approved these changes
Jan 20, 2021
CFrez
pushed a commit
to CFrez/streamlit
that referenced
this pull request
Jan 21, 2021
\streamlit#2395 ended up being caused by this since we don't rerender placeholder components created by `st.empty()` when react props/state change as a performance optimization, but we need to do so when replacing an existing component with an empty one to get rid of what's currently drawn on screen. Closes streamlit#2395
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 25, 2021
* develop: ✨ Support "auto" as the new default for st.image's `use_column_width` (streamlit#2635) fix branch name in pr-preview (streamlit#2644) ♻️ Remove "_proto" from "exception_proto.py" (streamlit#2638) ♻️ Remove "_proto" from "media_proto.py" and "iframe_proto.py" (streamlit#2639) Refactor: remove "_proto" from "image_proto.py" (streamlit#2626) correct info on url shortening behavior (streamlit#2576) Set "overflow:visible" on st.expander (streamlit#2611) Revert "Revert "Add anchors to Markdown headers (streamlit#2513)"" Fix file uploader docs + change to getvalue (streamlit#2628) Update change log Update notices Up version to 0.75.0 Revert "Add anchors to Markdown headers (streamlit#2513)" Speed up Cypress tests (streamlit#2600) Remove "beta feature" notice on st.color_picker (streamlit#2625) Deflake multiselect snapshot test by waiting for stale-element (streamlit#2624) Rerender Maybe components when they're first disabled (streamlit#2617) Increase side padding to 5rem when app is in wide mode (streamlit#2613)
kmcgrady
pushed a commit
that referenced
this pull request
Jan 25, 2021
* switched react-katex package * lockfile updated * update test to corrected spelling * decapitalize KaTex * Fix slider UX (#2596) * Fix slider UX * Add snapshot * Revert "Deploy button front (#2552)" (#2599) * Revert "Deploy button front (#2552)" This reverts commit 0f66b6e. * Fix merge (erm... revert) conflict. * Revert "Deploy button py (#2535)" This reverts commit 0bbc7aa. Co-authored-by: karrie <karrie@streamlit.io> * Remove extra period from sentence (#2601) * Have st.number_input warn user of mismatched type and format string (#2604) * Add %u to list of valid number_input formatters * Have number_input warn user of mismatched type and format string * Use more modern f-string syntax instead of .format() * Feature/sudoless metrics (#2605) * Add and use sudoless machine id getter for metrics Step 2 of the metrics user ID improvement plan. * Add machine-id v3 tests Duplicates of the v1 tests, since those covered the cases that remain in v3, and we will remove v1 and its tests later. Also fix formatting of some python files. * DRY out machine ID paths into global constants * Increase side padding to 5rem when app is in wide mode (#2613) * Increase side padding to 5rem when app is in wide mode * Upload Cypress snapshot * Rerender Maybe components when they're first disabled (#2617) \#2395 ended up being caused by this since we don't rerender placeholder components created by `st.empty()` when react props/state change as a performance optimization, but we need to do so when replacing an existing component with an empty one to get rid of what's currently drawn on screen. Closes #2395 Co-authored-by: karrie <karrie@streamlit.io> Co-authored-by: Thiago Teixeira <thiago@streamlit.io> Co-authored-by: Randy Zwitch <randy@streamlit.io> Co-authored-by: Vincent Donato <vincent.rdonato@gmail.com> Co-authored-by: Amanda Walker <amanda@amandawalker.io> Co-authored-by: Austin Chen <akrolsmir@gmail.com> Co-authored-by: Vincent Donato <vincent@streamlit.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2395 ended up being caused by this since we don't rerender placeholder
components created by
st.empty()when react props/state change as aperformance optimization, but we need to do so when replacing an
existing component with an empty one to get rid of what's currently
drawn on screen.
Closes #2395