Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase side padding to 5rem when app is in wide mode #2613

Merged
merged 2 commits into from Jan 20, 2021
Merged

Increase side padding to 5rem when app is in wide mode #2613

merged 2 commits into from Jan 20, 2021

Conversation

akrolsmir
Copy link
Contributor

Fixes #2426

@akrolsmir akrolsmir requested a review from a team January 19, 2021 19:17
karriebear
karriebear reviewed Jan 19, 2021
View reviewed changes
e2e/specs/st_set_page_config.spec.js
cy.get("[data-testid='stReportViewContainer']").matchImageSnapshot(
"wide-mode"
);
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add an image snapshot. Otherwise this will always pass. You can pull it from CircleCI job

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for the clarification! I kinda assumed it would get created automatically once I pushed, didn't realize I have to manually copy it over as well.

@akrolsmir akrolsmir merged commit 419c858 into streamlit:develop Jan 20, 2021
CFrez pushed a commit to CFrez/streamlit that referenced this pull request Jan 21, 2021
@akrolsmir @CFrez
Increase side padding to 5rem when app is in wide mode (streamlit#2613)
903e8f3 
* Increase side padding to 5rem when app is in wide mode

* Upload Cypress snapshot
tconkling added a commit to tconkling/streamlit that referenced this pull request Jan 25, 2021
@tconkling
Merge branch 'develop' into tim/FormProto
5e10122 
* develop:
  ✨ Support "auto" as the new default for st.image's `use_column_width` (streamlit#2635)
  fix branch name in pr-preview (streamlit#2644)
  ♻️ Remove "_proto" from "exception_proto.py" (streamlit#2638)
  ♻️ Remove "_proto" from "media_proto.py" and "iframe_proto.py" (streamlit#2639)
  Refactor: remove "_proto" from "image_proto.py" (streamlit#2626)
  correct info on url shortening behavior (streamlit#2576)
  Set "overflow:visible" on st.expander (streamlit#2611)
  Revert "Revert "Add anchors to Markdown headers (streamlit#2513)""
  Fix file uploader docs + change to getvalue (streamlit#2628)
  Update change log
  Update notices
  Up version to 0.75.0
  Revert "Add anchors to Markdown headers (streamlit#2513)"
  Speed up Cypress tests (streamlit#2600)
  Remove "beta feature" notice on st.color_picker (streamlit#2625)
  Deflake multiselect snapshot test by waiting for stale-element (streamlit#2624)
  Rerender Maybe components when they're first disabled (streamlit#2617)
  Increase side padding to 5rem when app is in wide mode (streamlit#2613)
kmcgrady pushed a commit that referenced this pull request Jan 25, 2021
@CFrez @karriebear
@tvst @vdonato @AnOctopus @akrolsmir
Switched react-katex package (#2619)
2152e2a 
* switched react-katex package

* lockfile updated

* update test to corrected spelling

* decapitalize KaTex

* Fix slider UX (#2596)

* Fix slider UX

* Add snapshot

* Revert "Deploy button front (#2552)" (#2599)

* Revert "Deploy button front (#2552)"

This reverts commit 0f66b6e.

* Fix merge (erm... revert) conflict.

* Revert "Deploy button py (#2535)"

This reverts commit 0bbc7aa.

Co-authored-by: karrie <karrie@streamlit.io>

* Remove extra period from sentence (#2601)

* Have st.number_input warn user of mismatched type and format string (#2604)

* Add %u to list of valid number_input formatters

* Have number_input warn user of mismatched type and format string

* Use more modern f-string syntax instead of .format()

* Feature/sudoless metrics (#2605)

* Add and use sudoless machine id getter for metrics

Step 2 of the metrics user ID improvement plan.

* Add machine-id v3 tests

Duplicates of the v1 tests, since those covered the cases that remain in v3,
and we will remove v1 and its tests later.

Also fix formatting of some python files.

* DRY out machine ID paths into global constants

* Increase side padding to 5rem when app is in wide mode (#2613)

* Increase side padding to 5rem when app is in wide mode

* Upload Cypress snapshot

* Rerender Maybe components when they're first disabled (#2617)

\#2395 ended up being caused by this since we don't rerender placeholder
components created by `st.empty()` when react props/state change as a
performance optimization, but we need to do so when replacing an
existing component with an empty one to get rid of what's currently
drawn on screen.

Closes #2395

Co-authored-by: karrie <karrie@streamlit.io>
Co-authored-by: Thiago Teixeira <thiago@streamlit.io>
Co-authored-by: Randy Zwitch <randy@streamlit.io>
Co-authored-by: Vincent Donato <vincent.rdonato@gmail.com>
Co-authored-by: Amanda Walker <amanda@amandawalker.io>
Co-authored-by: Austin Chen <akrolsmir@gmail.com>
Co-authored-by: Vincent Donato <vincent@streamlit.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karriebear karriebear karriebear approved these changes

Assignees

@karriebear karriebear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

st.set_page_config(layout="wide") needs more padding
2 participants
@akrolsmir @karriebear